github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-07-21 17:54:28 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #2139] [CLOSED] [PS-1689] Add support for copying some identity fields #3381

New Issue
Closed
opened 2025-11-26 23:31:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:58 -06:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2139
Author: @laurelmay
Created: 10/15/2022
Status: ❌ Closed

Base: master ← Head: allow-copying-identity-fields

📝 Commits (1)

  • 6bd410c Add support for copying some identity fields

📊 Changes

5 files changed (+201 additions, -21 deletions)

View changed files

📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+109 -21)
📝 src/App/Pages/Vault/CipherDetailsPageViewModel.cs (+20 -0)
📝 src/App/Resources/AppResources.Designer.cs (+36 -0)
📝 src/App/Resources/AppResources.resx (+16 -0)
📝 src/App/Utilities/AppHelpers.cs (+20 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This allows for copying the identity's email address, passport number,
SSN, and license number; it follows the pattern primarily for copying
username and card details.

Implements part of https://community.bitwarden.com/t/allow-copying-of-default-identity-fields/1109

Code changes

  • src/App/Pages/Vault/CipherDetailsPage.xaml: Updated the views to add the copy button

  • src/App/Pages/Vault/CipherDetailsPageViewModel.cs: Adds support for the new commands, following the pattern for Username

  • src/App/Resources/AppResources.Designer.cs: Adds the new resources

  • src/App/Resources/AppResources.resx: Adds the new strings

  • src/App/Utilities/AppHelpers.cs: Adds helpers for the actions

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2139 **Author:** [@laurelmay](https://github.com/laurelmay) **Created:** 10/15/2022 **Status:** ❌ Closed **Base:** `master` ← **Head:** `allow-copying-identity-fields` --- ### 📝 Commits (1) - [`6bd410c`](https://github.com/bitwarden/android/commit/6bd410c300540831c6d872146eda709effb745d2) Add support for copying some identity fields ### 📊 Changes **5 files changed** (+201 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+109 -21) 📝 `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` (+20 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+36 -0) 📝 `src/App/Resources/AppResources.resx` (+16 -0) 📝 `src/App/Utilities/AppHelpers.cs` (+20 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> This allows for copying the identity's email address, passport number, SSN, and license number; it follows the pattern primarily for copying username and card details. Implements part of https://community.bitwarden.com/t/allow-copying-of-default-identity-fields/1109 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Vault/CipherDetailsPage.xaml**: Updated the views to add the copy button * **src/App/Pages/Vault/CipherDetailsPageViewModel.cs**: Adds support for the new commands, following the pattern for Username * **src/App/Resources/AppResources.Designer.cs**: Adds the new resources * **src/App/Resources/AppResources.resx**: Adds the new strings * **src/App/Utilities/AppHelpers.cs**: Adds helpers for the actions * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3381