github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 11:29:37 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #2007] [MERGED] PS-1116 Improved network error handling #33788

New Issue
Closed
opened 2026-04-21 01:30:16 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:30:16 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2007
Author: @aj-rosado
Created: 7/22/2022
Status: ✅ Merged
Merged: 7/27/2022
Merged by: @aj-rosado

Base: master ← Head: bug/PS-1116-Added-network-exception-handles

📝 Commits (9)

  • 65cda00 PS-1116 Improved network error handling on ViewPageViewModel and AddEditPageViewModel
  • a2513a7 PS-1116 Renamed ViewPage and AddEditPage pages to a more explicit name.
  • c7dc65f Merge branch 'master' into bug/PS-1116-Added-network-exception-handles
  • 55cfcec PS-1116 Updated variables relative to the AddEditPage and ViewPage refactor to CipherAddEditPage and CipherDetailPage
  • 1a74f11 Renamed CipherDetailPage to CipherDetailsPage
  • f84cbfa Code improvement
  • b315a28 PS-1116 Improved code formatting
  • 65bbb6c PS-1116 Improved formatting
  • dfcd132 PS-1116 Improved code formatting

📊 Changes

14 files changed (+204 additions, -217 deletions)

View changed files

📝 src/App/App.csproj (+4 -4)
📝 src/App/App.xaml.cs (+5 -5)
📝 src/App/Pages/Vault/AutofillCiphersPage.xaml.cs (+2 -2)
➕ src/App/Pages/Vault/BaseCipherViewModel.cs (+76 -0)
📝 src/App/Pages/Vault/CipherAddEditPage.xaml (+4 -4)
📝 src/App/Pages/Vault/CipherAddEditPage.xaml.cs (+7 -7)
📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+19 -59)
📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+4 -4)
📝 src/App/Pages/Vault/CipherDetailsPage.xaml.cs (+10 -10)
📝 src/App/Pages/Vault/CipherDetailsPageViewModel.cs (+65 -113)
📝 src/App/Pages/Vault/CiphersPageViewModel.cs (+1 -2)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+3 -3)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+1 -1)
📝 src/App/Utilities/AppHelpers.cs (+3 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added and improved error handling on methods with network calls

Code changes

  • ViewPageViewModel, AddEditViewPage: Changed async commands to the proper method and added try catch to the CheckPassword method

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2007 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 7/22/2022 **Status:** ✅ Merged **Merged:** 7/27/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `bug/PS-1116-Added-network-exception-handles` --- ### 📝 Commits (9) - [`65cda00`](https://github.com/bitwarden/android/commit/65cda008243ddcade4e869b3460c69970cc3fa6e) PS-1116 Improved network error handling on ViewPageViewModel and AddEditPageViewModel - [`a2513a7`](https://github.com/bitwarden/android/commit/a2513a70ae47d2627de7e027a0c0386acd5f547d) PS-1116 Renamed ViewPage and AddEditPage pages to a more explicit name. - [`c7dc65f`](https://github.com/bitwarden/android/commit/c7dc65f82e1e216be90d90b1a88968625a46af03) Merge branch 'master' into bug/PS-1116-Added-network-exception-handles - [`55cfcec`](https://github.com/bitwarden/android/commit/55cfcec1afd3beaf4a06a1e89d4b05d5fa4c23a4) PS-1116 Updated variables relative to the AddEditPage and ViewPage refactor to CipherAddEditPage and CipherDetailPage - [`1a74f11`](https://github.com/bitwarden/android/commit/1a74f11ff9506d84508acc8b87b8c2947c8e12da) Renamed CipherDetailPage to CipherDetailsPage - [`f84cbfa`](https://github.com/bitwarden/android/commit/f84cbfacd235140931bc6e2a9e4dcff1a1cfba2a) Code improvement - [`b315a28`](https://github.com/bitwarden/android/commit/b315a28329f98fc76bdfd7f15ff7496b04e04b3d) PS-1116 Improved code formatting - [`65bbb6c`](https://github.com/bitwarden/android/commit/65bbb6cbfba0ed9b36ef2d8cbfe247e17b06094f) PS-1116 Improved formatting - [`dfcd132`](https://github.com/bitwarden/android/commit/dfcd1327485bbfe3ec880f85f8b909ccedfd25d5) PS-1116 Improved code formatting ### 📊 Changes **14 files changed** (+204 additions, -217 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+4 -4) 📝 `src/App/App.xaml.cs` (+5 -5) 📝 `src/App/Pages/Vault/AutofillCiphersPage.xaml.cs` (+2 -2) ➕ `src/App/Pages/Vault/BaseCipherViewModel.cs` (+76 -0) 📝 `src/App/Pages/Vault/CipherAddEditPage.xaml` (+4 -4) 📝 `src/App/Pages/Vault/CipherAddEditPage.xaml.cs` (+7 -7) 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+19 -59) 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+4 -4) 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml.cs` (+10 -10) 📝 `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` (+65 -113) 📝 `src/App/Pages/Vault/CiphersPageViewModel.cs` (+1 -2) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+3 -3) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+1 -1) 📝 `src/App/Utilities/AppHelpers.cs` (+3 -3) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Added and improved error handling on methods with network calls ## Code changes * **ViewPageViewModel, AddEditViewPage:** Changed async commands to the proper method and added try catch to the CheckPassword method ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:30:17 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#33788
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?