github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2135] [MERGED] [SG-705] Popup when a request for authentication comes in on a logged-in account that is not active #3378

New Issue
Closed
opened 2025-11-26 23:31:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2135
Author: @andrebispo5
Created: 10/14/2022
Status: ✅ Merged
Merged: 10/18/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-705-pop-account-switch

📝 Commits (10+)

  • d680127 [SG-705] Added pop up to perform account switching if the user receives a login request from another account.
  • 844db15 Merge branch 'master' into bugfix/SG-705-pop-account-switch
  • 5b400a9 [SG-705] missing resource designer
  • b5c0b50 [SG-705] Fixed wrong key for state service variable.
  • 61d1232 Merge branch 'master' into bugfix/SG-705-pop-account-switch
  • f256a9b [SG-705] PR fixes
  • da54005 [SG-705] remove test code.
  • e97461a [SG-705] Fix formatting of account switch alert.
  • 6d30b7e Merge branch 'master' into bugfix/SG-705-pop-account-switch
  • 1ac1ee4 [SG-705] Fix build

📊 Changes

7 files changed (+242 additions, -207 deletions)

View changed files

📝 src/App/App.xaml.cs (+27 -1)
📝 src/App/Resources/AppResources.Designer.cs (+195 -185)
📝 src/App/Resources/AppResources.resx (+5 -0)
📝 src/App/Services/PushNotificationListenerService.cs (+4 -8)
📝 src/Core/Abstractions/IStateService.cs (+2 -2)
📝 src/Core/Constants.cs (+1 -1)
📝 src/Core/Services/StateService.cs (+8 -10)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add popup notification when a request for authentication comes in on a logged-in account that is not active.

Code changes

Changed the GetPasswordlessLoginNotificationAsync to not be user specific to make it easier to check the user the request was from instead of having to iterate between all available users in the device and perform checks.

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2135 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/14/2022 **Status:** ✅ Merged **Merged:** 10/18/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-705-pop-account-switch` --- ### 📝 Commits (10+) - [`d680127`](https://github.com/bitwarden/android/commit/d6801273c2d0ff78cacc07de51ec3e35b83ba654) [SG-705] Added pop up to perform account switching if the user receives a login request from another account. - [`844db15`](https://github.com/bitwarden/android/commit/844db1509d423e705a1a13eb4d965c239103b9be) Merge branch 'master' into bugfix/SG-705-pop-account-switch - [`5b400a9`](https://github.com/bitwarden/android/commit/5b400a9c3aff3343f0a9f9a05bb46cb68edab9f0) [SG-705] missing resource designer - [`b5c0b50`](https://github.com/bitwarden/android/commit/b5c0b502af8c9cfc8193b9f575fd61754efbd652) [SG-705] Fixed wrong key for state service variable. - [`61d1232`](https://github.com/bitwarden/android/commit/61d12327db28293a5237935561cf1240553044d9) Merge branch 'master' into bugfix/SG-705-pop-account-switch - [`f256a9b`](https://github.com/bitwarden/android/commit/f256a9b141dc2c4ffdfc6d9b10eff0f1dd3b396b) [SG-705] PR fixes - [`da54005`](https://github.com/bitwarden/android/commit/da540054d4cded247c171a6db3b2ce31facbe083) [SG-705] remove test code. - [`e97461a`](https://github.com/bitwarden/android/commit/e97461a5774bbedb5393347913c389e02eeb038f) [SG-705] Fix formatting of account switch alert. - [`6d30b7e`](https://github.com/bitwarden/android/commit/6d30b7e8e8a35692c1f2c661c56f9ebc34fecc47) Merge branch 'master' into bugfix/SG-705-pop-account-switch - [`1ac1ee4`](https://github.com/bitwarden/android/commit/1ac1ee47632ecfa717a7ea216c9be999d28353c9) [SG-705] Fix build ### 📊 Changes **7 files changed** (+242 additions, -207 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+27 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+195 -185) 📝 `src/App/Resources/AppResources.resx` (+5 -0) 📝 `src/App/Services/PushNotificationListenerService.cs` (+4 -8) 📝 `src/Core/Abstractions/IStateService.cs` (+2 -2) 📝 `src/Core/Constants.cs` (+1 -1) 📝 `src/Core/Services/StateService.cs` (+8 -10) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add popup notification when a request for authentication comes in on a logged-in account that is not active. ## Code changes Changed the `GetPasswordlessLoginNotificationAsync` to not be user specific to make it easier to check the user the request was from instead of having to iterate between all available users in the device and perform checks. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="390" alt="image" src="https://user-images.githubusercontent.com/4648522/196442063-30667b53-7377-4746-ac46-c0883f15d73b.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3378
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?