github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2134] [MERGED] [SG-703] Login request is not removed after dismissing push notification #3377

New Issue
Closed
opened 2025-11-26 23:31:55 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:55 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2134
Author: @andrebispo5
Created: 10/14/2022
Status: ✅ Merged
Merged: 10/14/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-703-ios-not-dismissed

📝 Commits (4)

  • f9cdf41 [SG-703] Added category to iOS notifications in order to be able to receive dismiss actions
  • 560c223 Merge branch 'master' into bugfix/SG-703-ios-not-dismissed
  • 8b3e53d Merge branch 'master' into bugfix/SG-703-ios-not-dismissed
  • 1af34eb [SG-703] PR Fix

📊 Changes

2 files changed (+9 additions, -1 deletions)

View changed files

📝 src/Core/Constants.cs (+2 -0)
📝 src/iOS/Services/iOSPushNotificationService.cs (+7 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Login request is not removed after dismissing push notification in iOS.

Code changes

Added category to iOS notifications in order to be able to receive dismiss/clear actions

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2134 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/14/2022 **Status:** ✅ Merged **Merged:** 10/14/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-703-ios-not-dismissed` --- ### 📝 Commits (4) - [`f9cdf41`](https://github.com/bitwarden/android/commit/f9cdf41ae8d855b2e808ab8679884de1fe9051ce) [SG-703] Added category to iOS notifications in order to be able to receive dismiss actions - [`560c223`](https://github.com/bitwarden/android/commit/560c22398a69974d02d122ea341de912b50eb40f) Merge branch 'master' into bugfix/SG-703-ios-not-dismissed - [`8b3e53d`](https://github.com/bitwarden/android/commit/8b3e53dbc4a91bee4ee80ad0274b96da2d636fd0) Merge branch 'master' into bugfix/SG-703-ios-not-dismissed - [`1af34eb`](https://github.com/bitwarden/android/commit/1af34eba0b1abdbed797b3c5db3bca9cd64f5f23) [SG-703] PR Fix ### 📊 Changes **2 files changed** (+9 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Core/Constants.cs` (+2 -0) 📝 `src/iOS/Services/iOSPushNotificationService.cs` (+7 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Login request is not removed after dismissing push notification in iOS. ## Code changes Added category to iOS notifications in order to be able to receive dismiss/clear actions ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:55 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3377
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?