github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2129] [MERGED] [SG-690] Passwordless Timeout fix #3373

New Issue
Closed
opened 2025-11-26 23:31:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2129
Author: @andrebispo5
Created: 10/12/2022
Status: ✅ Merged
Merged: 10/12/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-690-timeout-background

📝 Commits (2)

  • 10a81f7 [SG-690] Timeout fix
  • 3cd1a97 Merge branch 'master' into bugfix/SG-690-timeout-background

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+2 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

  1. Open login request once it’s received,
  2. Wait 15 minutes with app backgrounded
  3. Open app once expired

Expected: Displays alert that it’s expired, dismisses login request, redirects to vault
Actual: Displays alert that it’s expired, hangs on Bitwarden logo screen. Have to close and re-open app

Code changes

Datetime values were not matching.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2129 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 10/12/2022 **Status:** ✅ Merged **Merged:** 10/12/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-690-timeout-background` --- ### 📝 Commits (2) - [`10a81f7`](https://github.com/bitwarden/android/commit/10a81f7331c3307b4281e55159ebe6788dac1909) [SG-690] Timeout fix - [`3cd1a97`](https://github.com/bitwarden/android/commit/3cd1a9722ef75dcbb1015ee84d72582508b8c02a) Merge branch 'master' into bugfix/SG-690-timeout-background ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+2 -2) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> 1. Open login request once it’s received, 2. Wait 15 minutes with app backgrounded 3. Open app once expired Expected: Displays alert that it’s expired, dismisses login request, redirects to vault Actual: Displays alert that it’s expired, hangs on Bitwarden logo screen. Have to close and re-open app ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Datetime values were not matching. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3373
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?