github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 21:24:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2127] [MERGED] [EC-602] Constants namespace fix #3372

New Issue
Closed
opened 2025-11-26 23:31:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2127
Author: @fedemkr
Created: 10/11/2022
Status: ✅ Merged
Merged: 10/11/2022
Merged by: @fedemkr

Base: master ← Head: EC-602-package-name-const-fix

📝 Commits (1)

  • 2bc581f EC-602 Constants namespace fix

📊 Changes

7 files changed (+16 additions, -16 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+1 -1)
📝 src/Android/Autofill/AutofillService.cs (+1 -1)
📝 src/Android/Autofill/Parser.cs (+1 -1)
📝 src/Android/MainActivity.cs (+6 -6)
📝 src/Android/MainApplication.cs (+2 -2)
📝 src/Android/Services/AndroidPushNotificationService.cs (+2 -2)
📝 src/Android/Services/DeviceActionService.cs (+3 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix constants to include the Core namespace in Android so that it takes the right one

Code changes

  • all files: Specified the namespace of the Constants -> Core.Constants so that it doesn't take the new one for Android.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2127 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 10/11/2022 **Status:** ✅ Merged **Merged:** 10/11/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `EC-602-package-name-const-fix` --- ### 📝 Commits (1) - [`2bc581f`](https://github.com/bitwarden/android/commit/2bc581ff4e8ef35086622ccd33020a6dce58b3e7) EC-602 Constants namespace fix ### 📊 Changes **7 files changed** (+16 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+1 -1) 📝 `src/Android/Autofill/AutofillService.cs` (+1 -1) 📝 `src/Android/Autofill/Parser.cs` (+1 -1) 📝 `src/Android/MainActivity.cs` (+6 -6) 📝 `src/Android/MainApplication.cs` (+2 -2) 📝 `src/Android/Services/AndroidPushNotificationService.cs` (+2 -2) 📝 `src/Android/Services/DeviceActionService.cs` (+3 -3) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix constants to include the Core namespace in Android so that it takes the right one ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **all files:** Specified the namespace of the `Constants` -> `Core.Constants` so that it doesn't take the new one for Android. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3372
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?