github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 21:39:15 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #1822] [MERGED] Add url encoding to data parameter #33656

New Issue
Closed
opened 2026-04-21 01:24:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 01:24:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1822
Author: @MGibson1
Created: 3/2/2022
Status: ✅ Merged
Merged: 3/2/2022
Merged by: @MGibson1

Base: master ← Head: fix/connector-data-component-url-encoding

📝 Commits (1)

  • f8c8d0d Add url encoding to data parameter

📊 Changes

1 file changed (+2 additions, -1 deletions)

View changed files

📝 src/App/Utilities/AppHelpers.cs (+2 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

URL encode base64 in url parameters. B64 include the + character, which is converted to a , which is not a valid base 64 character.

This was causing errors while loading our captcha connectors, and likely our 2fa connectors, for certain languages.

Testing requirements

Test captcha functionality with czech locale.
Should also test 2fa functionality, since that shares concerns here

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1822 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 3/2/2022 **Status:** ✅ Merged **Merged:** 3/2/2022 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `fix/connector-data-component-url-encoding` --- ### 📝 Commits (1) - [`f8c8d0d`](https://github.com/bitwarden/android/commit/f8c8d0d2a6cb827a95a4a33861052c1bab7203a9) Add url encoding to data parameter ### 📊 Changes **1 file changed** (+2 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Utilities/AppHelpers.cs` (+2 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective URL encode base64 in url parameters. B64 include the `+` character, which is converted to a ` `, which is _not_ a valid base 64 character. This was causing errors while loading our captcha connectors, and likely our 2fa connectors, for certain languages. ## Testing requirements Test captcha functionality with czech locale. Should also test 2fa functionality, since that shares concerns here ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 01:24:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#33656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?