github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2117] [CLOSED] [SG-690] DateTime to Utc fix (#2115) #3365

New Issue
Closed
opened 2025-11-26 23:31:45 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:45 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2117
Author: @trmartin4
Created: 10/5/2022
Status: ❌ Closed

Base: rc ← Head: gpg-test-rc

📝 Commits (3)

📊 Changes

2 files changed (+3 additions, -3 deletions)

View changed files

📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+2 -2)

📄 Description

  • SG-690 DateTime to Utc fix

  • SG-690 Removed Utc from server side datetime.

(cherry picked from commit 1e5eab0574)

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Changed the time comparison to be UTC.

Code changes

  • src/App/App.xaml.cs: Added UTC to time comparison
    src/App/Pages/Accounts/LoginPasswordlessViewModel.cs: Added UTC to time comparison

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2117 **Author:** [@trmartin4](https://github.com/trmartin4) **Created:** 10/5/2022 **Status:** ❌ Closed **Base:** `rc` ← **Head:** `gpg-test-rc` --- ### 📝 Commits (3) - [`6fe130e`](https://github.com/bitwarden/android/commit/6fe130e0a21976502465e6d6170a498f32d6af80) [SG-690] DateTime to Utc fix (#2115) - [`b372391`](https://github.com/bitwarden/android/commit/b372391499df71f8213920387630a361012d48e0) [SG-690] DateTime to Utc fix (#2115) - [`b00d321`](https://github.com/bitwarden/android/commit/b00d32135cf5ef05d9d6d4ad68ad0a5e64d61fb9) Merge branch 'gpg-test-rc' of https://github.com/bitwarden/mobile into gpg-test-rc ### 📊 Changes **2 files changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+2 -2) </details> ### 📄 Description * [SG-690] DateTime to Utc fix * [SG-690] Removed Utc from server side datetime. (cherry picked from commit 1e5eab057476295184a97102696a765a2b4387e6) ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Changed the time comparison to be UTC. ## Code changes * **src/App/App.xaml.cs:** Added UTC to time comparison **src/App/Pages/Accounts/LoginPasswordlessViewModel.cs:** Added UTC to time comparison ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team [SG-690]: https://bitwarden.atlassian.net/browse/SG-690?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [SG-690]: https://bitwarden.atlassian.net/browse/SG-690?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:45 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3365
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?