github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #2109] [MERGED] [SG-666][SG-667] Email is not prefilled and username isn't generated automatically #3358

New Issue
Closed
opened 2025-11-26 23:31:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2109
Author: @LRNcardozoWDF
Created: 10/3/2022
Status: ✅ Merged
Merged: 10/3/2022
Merged by: @LRNcardozoWDF

Base: master ← Head: bug/SG-666-email-is-not-prefilled

📝 Commits (4)

  • b3b2b85 SG-666 SG-667 - Email is now prefilled for plus addressed email username type
  • e318751 Merge branch 'master' into bug/SG-666-email-is-not-prefilled
  • 643beee Merge branch 'master' into bug/SG-666-email-is-not-prefilled
  • b099aae SG-666 - Fixed PR comments

📊 Changes

2 files changed (+38 additions, -17 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPageViewModel.cs (+35 -16)
📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+3 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With this changes email is now prefilled when selecting Plus Adressed Email username type, the username is generated automatically upon navigation and if the chosen item has an URI we pass it correctly as a field for Plus Adressed Email or Catch-all Email username types.

Code changes

  • GeneratorPageViewModel.cs: Now we fetch the user's email and generate automatically the username for all username types except UsernameType.ForwardedEmailAlias.
  • CipherAddEditPageViewModel.cs: Fixed the field sent to the generator page.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2109 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 10/3/2022 **Status:** ✅ Merged **Merged:** 10/3/2022 **Merged by:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Base:** `master` ← **Head:** `bug/SG-666-email-is-not-prefilled` --- ### 📝 Commits (4) - [`b3b2b85`](https://github.com/bitwarden/android/commit/b3b2b858bfeb18a7da9408b46c0f64238fd90f60) SG-666 SG-667 - Email is now prefilled for plus addressed email username type - [`e318751`](https://github.com/bitwarden/android/commit/e318751754269025bd33968515fd60a931c51451) Merge branch 'master' into bug/SG-666-email-is-not-prefilled - [`643beee`](https://github.com/bitwarden/android/commit/643beee8ad0149f6109005bf2f120015904b29f3) Merge branch 'master' into bug/SG-666-email-is-not-prefilled - [`b099aae`](https://github.com/bitwarden/android/commit/b099aae3e603e9b9ce3285d0f7ac7c825c3f269a) SG-666 - Fixed PR comments ### 📊 Changes **2 files changed** (+38 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPageViewModel.cs` (+35 -16) 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+3 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective With this changes email is now prefilled when selecting Plus Adressed Email username type, the username is generated automatically upon navigation and if the chosen item has an URI we pass it correctly as a field for Plus Adressed Email or Catch-all Email username types. ## Code changes * **GeneratorPageViewModel.cs:** Now we fetch the user's email and generate automatically the username for all username types except UsernameType.ForwardedEmailAlias. * **CipherAddEditPageViewModel.cs:** Fixed the field sent to the generator page. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3358
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?