github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 03:33:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2106] [MERGED] [SG-690] Login Request does not disappear after 15 minutes #3355

New Issue
Closed
opened 2025-11-26 23:31:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2106
Author: @andrebispo5
Created: 9/30/2022
Status: ✅ Merged
Merged: 9/30/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-690-notif_dismiss

📝 Commits (5)

  • 3cfefa9 [SG-690] Add timeout of 15 for android notifications. Add condition to not prompt login requests if 15mins have passed. Add constant for timeout time.
  • 43957ca [SG-690] Added dialog on click confirm/deny if the request is expired.
  • 7d977dd Merge branch 'master' into bugfix/SG-690-notif_dismiss
  • 4d0984c [SG-690] PR fixes
  • 62b980f [SG-690] PR fixes

📊 Changes

6 files changed (+3710 additions, -1478 deletions)

View changed files

📝 src/Android/Services/AndroidPushNotificationService.cs (+2 -2)
📝 src/App/App.xaml.cs (+4 -1)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+7 -0)
📝 src/App/Resources/AppResources.Designer.cs (+3693 -1475)
📝 src/App/Resources/AppResources.resx (+3 -0)
📝 src/Core/Constants.cs (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Login requests were supposed to be removed from the mobile device after 15 minutes had passed and they were expired. Currently, whether the login request is already open in the app, or you have not yet opened the app to view the request, the request does not disappear. This also leads to an issue where, if you approve/deny the login request, you receive a confusing error message stating that something went wrong.

Code changes

  • Before showing a modal, the app checks if the request is expired and silently ignores it.
  • When already showing the modal, if the user clicks Confirm/Deny the app checks if the request is expired and shows a dialog. When the dialog is closed, the modal is also closed and the request is ignored.

On Android:

  • After 15mins the system notification is automatically dismissed.

Screenshots

image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2106 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/30/2022 **Status:** ✅ Merged **Merged:** 9/30/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-690-notif_dismiss` --- ### 📝 Commits (5) - [`3cfefa9`](https://github.com/bitwarden/android/commit/3cfefa97dd6a686f1fa0eeb963bed7130d5639ca) [SG-690] Add timeout of 15 for android notifications. Add condition to not prompt login requests if 15mins have passed. Add constant for timeout time. - [`43957ca`](https://github.com/bitwarden/android/commit/43957ca0a9292f1db3607959255acc43067b8866) [SG-690] Added dialog on click confirm/deny if the request is expired. - [`7d977dd`](https://github.com/bitwarden/android/commit/7d977dd6cc0e6f7ac20cedee97cd6cf80f2b558b) Merge branch 'master' into bugfix/SG-690-notif_dismiss - [`4d0984c`](https://github.com/bitwarden/android/commit/4d0984c46ab98476a0d16a28807e0a09959be6b3) [SG-690] PR fixes - [`62b980f`](https://github.com/bitwarden/android/commit/62b980fd58eb0fa3d74fef4cbb2f90e5f1e12b09) [SG-690] PR fixes ### 📊 Changes **6 files changed** (+3710 additions, -1478 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/AndroidPushNotificationService.cs` (+2 -2) 📝 `src/App/App.xaml.cs` (+4 -1) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+7 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+3693 -1475) 📝 `src/App/Resources/AppResources.resx` (+3 -0) 📝 `src/Core/Constants.cs` (+1 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Login requests were supposed to be removed from the mobile device after 15 minutes had passed and they were expired. Currently, whether the login request is already open in the app, or you have not yet opened the app to view the request, the request does not disappear. This also leads to an issue where, if you approve/deny the login request, you receive a confusing error message stating that something went wrong. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> - Before showing a modal, the app checks if the request is expired and silently ignores it. - When already showing the modal, if the user clicks Confirm/Deny the app checks if the request is expired and shows a dialog. When the dialog is closed, the modal is also closed and the request is ignored. On Android: - After 15mins the system notification is automatically dismissed. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![image](https://user-images.githubusercontent.com/4648522/193290907-6b335aff-f59e-4959-aacb-70f023f899b7.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3355
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?