github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 06:11:38 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2105] [MERGED] [SG-696] Android notification icon blank #3354

New Issue
Closed
opened 2025-11-26 23:31:37 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:37 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2105
Author: @andrebispo5
Created: 9/30/2022
Status: ✅ Merged
Merged: 9/30/2022
Merged by: @andrebispo5

Base: master ← Head: bugfix/SG-696-droid-notif-icon

📝 Commits (3)

  • 569924b [SG-696] Added new icon for android notifications. Changed notification intent flags to use helper.
  • a691138 Merge branch 'master' into bugfix/SG-696-droid-notif-icon
  • 1dcc97a [SG-696] PR fix. Min version was already 21.

📊 Changes

3 files changed (+16 additions, -3 deletions)

View changed files

📝 src/Android/Android.csproj (+4 -0)
➕ src/Android/Resources/drawable/ic_notification.xml (+4 -0)
📝 src/Android/Services/AndroidPushNotificationService.cs (+8 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix blank notification icon on android.

Code changes

Added new notification icon monochrome.
Changed pending intent flags to use AndroidHelper

Screenshots

image image image image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2105 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/30/2022 **Status:** ✅ Merged **Merged:** 9/30/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bugfix/SG-696-droid-notif-icon` --- ### 📝 Commits (3) - [`569924b`](https://github.com/bitwarden/android/commit/569924b1f6d68a5ad82fe91a07651cca1721a3ae) [SG-696] Added new icon for android notifications. Changed notification intent flags to use helper. - [`a691138`](https://github.com/bitwarden/android/commit/a6911383679c17ff17f6dfcc2e508208c7182891) Merge branch 'master' into bugfix/SG-696-droid-notif-icon - [`1dcc97a`](https://github.com/bitwarden/android/commit/1dcc97af1de3682a870bfa7e1aa45697641117e3) [SG-696] PR fix. Min version was already 21. ### 📊 Changes **3 files changed** (+16 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+4 -0) ➕ `src/Android/Resources/drawable/ic_notification.xml` (+4 -0) 📝 `src/Android/Services/AndroidPushNotificationService.cs` (+8 -3) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix blank notification icon on android. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Added new notification icon monochrome. Changed pending intent flags to use `AndroidHelper` ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="191" alt="image" src="https://user-images.githubusercontent.com/4648522/193260994-c0c55512-2e0d-4968-b29f-559d3d45a1db.png"> <img width="289" alt="image" src="https://user-images.githubusercontent.com/4648522/193260997-5d86bb1d-1833-47a7-adf3-8e454947c10f.png"> <img width="161" alt="image" src="https://user-images.githubusercontent.com/4648522/193261017-be79c17f-d1dd-4a63-8639-ab8b8c0d8cc7.png"> <img width="263" alt="image" src="https://user-images.githubusercontent.com/4648522/193261006-ffa067d2-3513-405d-80c0-4481bcbf1f6d.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:37 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3354
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?