github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-11 20:54:58 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2102] [MERGED] Added accessibility service disclosure prompt for Android #3352

New Issue
Closed
opened 2025-11-26 23:31:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2102
Author: @mpbw2
Created: 9/27/2022
Status: ✅ Merged
Merged: 9/27/2022
Merged by: @mpbw2

Base: master ← Head: feature-a11y-disclosure

📝 Commits (3)

  • 69bd1f7 added a11y disclosure prompt for Android
  • 6fbe53e cleanup
  • 0518353 add isAccessibilityTool to service metadata

📊 Changes

6 files changed (+64 additions, -16 deletions)

View changed files

📝 src/Android/Resources/xml/accessibilityservice.xml (+2 -1)
📝 src/App/Pages/Settings/AutofillServicesPage.xaml (+1 -1)
📝 src/App/Pages/Settings/AutofillServicesPage.xaml.cs (+0 -8)
📝 src/App/Pages/Settings/AutofillServicesPageViewModel.cs (+21 -1)
📝 src/App/Resources/AppResources.Designer.cs (+28 -5)
📝 src/App/Resources/AppResources.resx (+12 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Now that we're targeting API 32 we're required to comply with this policy regarding non-accessibility apps using accessibility services. This PR adds the disclosure and consent prompt as described on the help page.

Code changes

  • AutofillServicesPage.xaml/xaml.cs/ViewModel.cs: Added support for showing disclosure dialog when the user enables the accessibility switch, and requires acceptance before continuing to the Android accessibility settings screen to enable the service.
  • accessibilityservice.xml: Added isAccessibilityTool="false" per documentation (already defaults to false but added for completeness)

Screenshots

01

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2102 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 9/27/2022 **Status:** ✅ Merged **Merged:** 9/27/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-a11y-disclosure` --- ### 📝 Commits (3) - [`69bd1f7`](https://github.com/bitwarden/android/commit/69bd1f716bbc899a254ccdea4a58458514853972) added a11y disclosure prompt for Android - [`6fbe53e`](https://github.com/bitwarden/android/commit/6fbe53e3d58442462efa460dbc8c12360697d415) cleanup - [`0518353`](https://github.com/bitwarden/android/commit/05183537d3303bc1a58ff41bdf6037730dfe1a8f) add isAccessibilityTool to service metadata ### 📊 Changes **6 files changed** (+64 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Resources/xml/accessibilityservice.xml` (+2 -1) 📝 `src/App/Pages/Settings/AutofillServicesPage.xaml` (+1 -1) 📝 `src/App/Pages/Settings/AutofillServicesPage.xaml.cs` (+0 -8) 📝 `src/App/Pages/Settings/AutofillServicesPageViewModel.cs` (+21 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+28 -5) 📝 `src/App/Resources/AppResources.resx` (+12 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Now that we're targeting API 32 we're required to comply with [this policy regarding non-accessibility apps using accessibility services](https://support.google.com/googleplay/android-developer/answer/10964491). This PR adds the disclosure and consent prompt as described on the help page. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AutofillServicesPage.xaml/xaml.cs/ViewModel.cs:** Added support for showing disclosure dialog when the user enables the accessibility switch, and requires acceptance before continuing to the Android accessibility settings screen to enable the service. * **accessibilityservice.xml:** Added `isAccessibilityTool="false"` per documentation (already defaults to `false` but added for completeness) ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![01](https://user-images.githubusercontent.com/59324545/192422035-65569cc6-a540-4e34-9c17-3893ccdc877d.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3352
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?