github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-23 22:51:40 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #2095] [MERGED] [PS-1543]Sentence case mobile #3346

New Issue
Closed
opened 2025-11-26 23:31:31 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:31 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2095
Author: @danielleflinn
Created: 9/22/2022
Status: ✅ Merged
Merged: 10/13/2022
Merged by: @danielleflinn

Base: master ← Head: sentence-case-mobile

📝 Commits (4)

  • 46446ed transitioned to sentence case
  • 16d819a title case Social Security
  • 937123a removed unnecessary punctuation
  • 9e1ab25 Fixed missed modal buttons

📊 Changes

1 file changed (+185 additions, -185 deletions)

View changed files

📝 src/App/Resources/AppResources.resx (+185 -185)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Currently the use of Title and Sentence case is inconsistent throughout the product. To improve the UI consistency, readability, and localization, this change updates strings to use sentence case.

Code changes

src/App/Resources/AppResources.resx

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2095 **Author:** [@danielleflinn](https://github.com/danielleflinn) **Created:** 9/22/2022 **Status:** ✅ Merged **Merged:** 10/13/2022 **Merged by:** [@danielleflinn](https://github.com/danielleflinn) **Base:** `master` ← **Head:** `sentence-case-mobile` --- ### 📝 Commits (4) - [`46446ed`](https://github.com/bitwarden/android/commit/46446ed6e0854b7d15fc5ebc4d26b8d022beeb71) transitioned to sentence case - [`16d819a`](https://github.com/bitwarden/android/commit/16d819a90d1349bffdd5409c581c51fbdb76c69d) title case Social Security - [`937123a`](https://github.com/bitwarden/android/commit/937123a8bb4672e199a19a6a2e21ce4c0b1b7477) removed unnecessary punctuation - [`9e1ab25`](https://github.com/bitwarden/android/commit/9e1ab2549bdcb5a7e93aa29348dff4e7064dd9b6) Fixed missed modal buttons ### 📊 Changes **1 file changed** (+185 additions, -185 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Resources/AppResources.resx` (+185 -185) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective Currently the use of Title and Sentence case is inconsistent throughout the product. To improve the UI consistency, readability, and localization, this change updates strings to use sentence case. ## Code changes src/App/Resources/AppResources.resx ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:31 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3346
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?