github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2088] [MERGED] [PS-1312] Update NFCAdapter mutability flag #3342

New Issue
Closed
opened 2025-11-26 23:31:28 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:28 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2088
Author: @aj-rosado
Created: 9/21/2022
Status: ✅ Merged
Merged: 9/21/2022
Merged by: @aj-rosado

Base: master ← Head: feature/PS-1312-update-android12-new-splashscreen

📝 Commits (10+)

  • 4cbaf3e [PS-1312] Updated Android Target and Framework to Android12 and updated new SplashScreen for Android12
  • f655108 Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen
  • e447aba PS-1312 Changed PendingIntents mutability
  • 37bee88 PS-1312 Removed unused imports
  • 227e1c9 PS-1312 Added method to helper to add mutability option according to Android version
  • 16a9e6c PS-1312 Renamed helper method AddPendingIntentMutability and fixed validation
  • 1f1cc3d PS-1312 Improved PendingIntentMutability method from helper readability and naming
  • 8b10dae Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen
  • fce1a93 Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen
  • 2644782 PS-1312 - Changed NFC Adapter PendingIntent to mutable

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/Android/MainActivity.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Some devices are having problems using the Yubikey. Updated the NFCAdapter PendingIntent to be mutable.

Code changes

  • MainActivity.cs: Changed to mutable the PendingIntent used by NFCAdapter to EnableForegroundDispatch

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2088 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/21/2022 **Status:** ✅ Merged **Merged:** 9/21/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `feature/PS-1312-update-android12-new-splashscreen` --- ### 📝 Commits (10+) - [`4cbaf3e`](https://github.com/bitwarden/android/commit/4cbaf3e29e12d4385ee490a54714c5afd7e5a7d8) [PS-1312] Updated Android Target and Framework to Android12 and updated new SplashScreen for Android12 - [`f655108`](https://github.com/bitwarden/android/commit/f65510839756bc835b4a2a0e6a2de8b2d7d5cf3d) Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen - [`e447aba`](https://github.com/bitwarden/android/commit/e447aba73d4950077cf47ed5c4f9809a7b8e6467) PS-1312 Changed PendingIntents mutability - [`37bee88`](https://github.com/bitwarden/android/commit/37bee88640775fdebe7e8ceab669fb25f5ebfa32) PS-1312 Removed unused imports - [`227e1c9`](https://github.com/bitwarden/android/commit/227e1c9b2434911abdff7a5fe6ae37feb816999c) PS-1312 Added method to helper to add mutability option according to Android version - [`16a9e6c`](https://github.com/bitwarden/android/commit/16a9e6c6b32b3889620124441b29a59a8e48a011) PS-1312 Renamed helper method AddPendingIntentMutability and fixed validation - [`1f1cc3d`](https://github.com/bitwarden/android/commit/1f1cc3d5fb6225de8ad62d38a5d5cadeac49f594) PS-1312 Improved PendingIntentMutability method from helper readability and naming - [`8b10dae`](https://github.com/bitwarden/android/commit/8b10dae7f19c4aa09617aea9b0906423203fa13a) Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen - [`fce1a93`](https://github.com/bitwarden/android/commit/fce1a9378c999d195b06d73a6e990b76bfa77d95) Merge branch 'master' into feature/PS-1312-update-android12-new-splashscreen - [`2644782`](https://github.com/bitwarden/android/commit/26447826c43fdba634f5e76c4853a00e31b971f9) PS-1312 - Changed NFC Adapter PendingIntent to mutable ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Some devices are having problems using the Yubikey. Updated the NFCAdapter PendingIntent to be mutable. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **MainActivity.cs:** Changed to mutable the PendingIntent used by NFCAdapter to EnableForegroundDispatch ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:28 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3342
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?