github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2084] [MERGED] [Android] Added shadowless version of monochrome launcher icon #3341

New Issue
Closed
opened 2025-11-26 23:31:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2084
Author: @mpbw2
Created: 9/19/2022
Status: ✅ Merged
Merged: 9/20/2022
Merged by: @mpbw2

Base: master ← Head: shadowless-mono-icon

📝 Commits (2)

  • e392e49 Added shadowless version of monochrome launcher icon
  • c29916e added missing project ref

📊 Changes

4 files changed (+18 additions, -2 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -0)
➕ src/Android/Resources/drawable/ic_launcher_monochrome.xml (+15 -0)
📝 src/Android/Resources/mipmap-anydpi-v26/ic_launcher.xml (+1 -1)
📝 src/Android/Resources/mipmap-anydpi-v26/ic_launcher_round.xml (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Added a version of the launcher icon (shield) without the material shadow

Code changes

  • ic_launcher_monochrome.xml: Copy of ic_launcher_foreground.xml with the shadow path removed
  • ic_launcher/ic_launcher_round.xml: Changed monochrome ref to point to new file

Screenshots

01
02

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2084 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 9/19/2022 **Status:** ✅ Merged **Merged:** 9/20/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `shadowless-mono-icon` --- ### 📝 Commits (2) - [`e392e49`](https://github.com/bitwarden/android/commit/e392e49ea04759f0fed484b8a771aa57ff004eb6) Added shadowless version of monochrome launcher icon - [`c29916e`](https://github.com/bitwarden/android/commit/c29916ee3dfa524cbe5b7ceb9d57ba9072990588) added missing project ref ### 📊 Changes **4 files changed** (+18 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -0) ➕ `src/Android/Resources/drawable/ic_launcher_monochrome.xml` (+15 -0) 📝 `src/Android/Resources/mipmap-anydpi-v26/ic_launcher.xml` (+1 -1) 📝 `src/Android/Resources/mipmap-anydpi-v26/ic_launcher_round.xml` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [X] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Added a version of the launcher icon (shield) without the material shadow ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ic_launcher_monochrome.xml:** Copy of `ic_launcher_foreground.xml` with the shadow path removed * **ic_launcher/ic_launcher_round.xml:** Changed monochrome ref to point to new file ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![01](https://user-images.githubusercontent.com/59324545/191284018-d0505e1f-185e-4286-9619-4909401c0a24.png) ![02](https://user-images.githubusercontent.com/59324545/191284035-e8d26d13-c233-4da3-aa85-a8c82a04f38d.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3341
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?