github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 04:03:24 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2079] [MERGED] [SG-169] Passwordless demo change requests #3339

New Issue
Closed
opened 2025-11-26 23:31:26 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:26 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2079
Author: @andrebispo5
Created: 9/16/2022
Status: ✅ Merged
Merged: 9/20/2022
Merged by: @andrebispo5

Base: feature/feature-passwordless-login ← Head: feature/passwordless-demo-fixes

📝 Commits (7)

  • c244146 [SG-169] End-to-end testing refactor.
  • 48db701 [SG-169] Fixed labels. Changed color of Fingerprint phrase. Waited for app to be in foreground to launch passwordless modal to fix Android issues.
  • b3d9f2f [SG-169] Anchored buttons to the bottom of the screen.
  • 38830c1 [SG-169] Changed device type from enum to string.
  • 392dd27 [SG-169] PR fixes
  • 8ea5de7 [SG-169] PR fixes
  • af43f29 [SG-169] Added comment on static variable

📊 Changes

14 files changed (+114 additions, -110 deletions)

View changed files

📝 src/Android/Services/AndroidPushNotificationService.cs (+1 -1)
📝 src/App/App.xaml.cs (+27 -2)
📝 src/App/Pages/Accounts/LoginPasswordlessPage.xaml (+54 -49)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+12 -42)
📝 src/App/Resources/AppResources.resx (+10 -10)
📝 src/App/Services/PushNotificationListenerService.cs (+1 -1)
📝 src/App/Styles/Black.xaml (+1 -0)
📝 src/App/Styles/Dark.xaml (+1 -0)
📝 src/App/Styles/Light.xaml (+1 -0)
📝 src/App/Styles/Nord.xaml (+1 -0)
📝 src/Core/Constants.cs (+0 -1)
📝 src/Core/Models/Response/PasswordlessLoginResponse.cs (+2 -1)
📝 src/Core/Services/ApiService.cs (+2 -2)
📝 src/Core/Services/AuthService.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Change requests from async demo of passwordless feature.

Code changes

Forced modal to appear after app came into foreground. Android was having erratic behaviour when the user had the app in background and clicked the received notification.

Screenshots

image
image

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2079 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/16/2022 **Status:** ✅ Merged **Merged:** 9/20/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/feature-passwordless-login` ← **Head:** `feature/passwordless-demo-fixes` --- ### 📝 Commits (7) - [`c244146`](https://github.com/bitwarden/android/commit/c244146415f67bec77ed2892cef2f35d6d0bf920) [SG-169] End-to-end testing refactor. - [`48db701`](https://github.com/bitwarden/android/commit/48db701237e470b5a8bb9fb4fa6d20629fd8b211) [SG-169] Fixed labels. Changed color of Fingerprint phrase. Waited for app to be in foreground to launch passwordless modal to fix Android issues. - [`b3d9f2f`](https://github.com/bitwarden/android/commit/b3d9f2f300ad8c741f867794ef99a57fe55d3dea) [SG-169] Anchored buttons to the bottom of the screen. - [`38830c1`](https://github.com/bitwarden/android/commit/38830c1ee2d6c258f8af429f82f4de5b232fa566) [SG-169] Changed device type from enum to string. - [`392dd27`](https://github.com/bitwarden/android/commit/392dd27523777ea64e5e4de7577688d94184648a) [SG-169] PR fixes - [`8ea5de7`](https://github.com/bitwarden/android/commit/8ea5de744314bde0550b29ec8865f74acd2f016e) [SG-169] PR fixes - [`af43f29`](https://github.com/bitwarden/android/commit/af43f29fb37452c7cd8120c582cc1e4bb7d560ad) [SG-169] Added comment on static variable ### 📊 Changes **14 files changed** (+114 additions, -110 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/AndroidPushNotificationService.cs` (+1 -1) 📝 `src/App/App.xaml.cs` (+27 -2) 📝 `src/App/Pages/Accounts/LoginPasswordlessPage.xaml` (+54 -49) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+12 -42) 📝 `src/App/Resources/AppResources.resx` (+10 -10) 📝 `src/App/Services/PushNotificationListenerService.cs` (+1 -1) 📝 `src/App/Styles/Black.xaml` (+1 -0) 📝 `src/App/Styles/Dark.xaml` (+1 -0) 📝 `src/App/Styles/Light.xaml` (+1 -0) 📝 `src/App/Styles/Nord.xaml` (+1 -0) 📝 `src/Core/Constants.cs` (+0 -1) 📝 `src/Core/Models/Response/PasswordlessLoginResponse.cs` (+2 -1) 📝 `src/Core/Services/ApiService.cs` (+2 -2) 📝 `src/Core/Services/AuthService.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Change requests from async demo of passwordless feature. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Forced modal to appear after app came into foreground. Android was having erratic behaviour when the user had the app in background and clicked the received notification. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![image](https://user-images.githubusercontent.com/4648522/190642027-962dce79-8af1-48f8-a710-bcea3c57e1f9.png) ![image](https://user-images.githubusercontent.com/4648522/190642062-b523785d-79f3-49a1-8feb-394e4caf1819.png) ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:26 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3339
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?