github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2078] [MERGED] PS-1404 Improved exception handling when saving an attachment #3338

New Issue
Closed
opened 2025-11-26 23:31:25 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:25 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2078
Author: @aj-rosado
Created: 9/16/2022
Status: ✅ Merged
Merged: 9/16/2022
Merged by: @aj-rosado

Base: master ← Head: bug/PS-1404-ios-app-not-responding-adding-attachment

📝 Commits (6)

  • 763bd6e PS-1404 Improved exception handling when saving an attachment
  • e469de1 PS-1404 Reverted unnecessary catch change
  • 49e8350 PS-1404 Added missing whitespace
  • c0c6fec PS-1404 Improved code formatting
  • df8c18f PS-1404 removed unnecessary whitespace
  • c784d18 PS-1404 Using SubmitAsyncCommand on xaml and removed the click method from the cs file

📊 Changes

3 files changed (+16 additions, -10 deletions)

View changed files

📝 src/App/Pages/Vault/AttachmentsPage.xaml (+1 -1)
📝 src/App/Pages/Vault/AttachmentsPage.xaml.cs (+0 -8)
📝 src/App/Pages/Vault/AttachmentsPageViewModel.cs (+15 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Prevent application from crashing when uploading a file.

Code changes

  • AttachmentPageViewModel.cs: Improved error handling and catching when saving an attachment

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2078 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 9/16/2022 **Status:** ✅ Merged **Merged:** 9/16/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `bug/PS-1404-ios-app-not-responding-adding-attachment` --- ### 📝 Commits (6) - [`763bd6e`](https://github.com/bitwarden/android/commit/763bd6e0a2dec655e9b88c3808c3dfeda072fe20) PS-1404 Improved exception handling when saving an attachment - [`e469de1`](https://github.com/bitwarden/android/commit/e469de12b6fe654343b258d0aaddedd60c91ecae) PS-1404 Reverted unnecessary catch change - [`49e8350`](https://github.com/bitwarden/android/commit/49e83500c8305e1b65111b7aadc23ff147a21c37) PS-1404 Added missing whitespace - [`c0c6fec`](https://github.com/bitwarden/android/commit/c0c6fec62527ed9d35ae81e0b02dfd9e4f23bd26) PS-1404 Improved code formatting - [`df8c18f`](https://github.com/bitwarden/android/commit/df8c18fa0f2b7dc3761b262aad6c322f485a77bf) PS-1404 removed unnecessary whitespace - [`c784d18`](https://github.com/bitwarden/android/commit/c784d18c5ffcc0ffe0576ef4a09a4654d91fe9b0) PS-1404 Using SubmitAsyncCommand on xaml and removed the click method from the cs file ### 📊 Changes **3 files changed** (+16 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/AttachmentsPage.xaml` (+1 -1) 📝 `src/App/Pages/Vault/AttachmentsPage.xaml.cs` (+0 -8) 📝 `src/App/Pages/Vault/AttachmentsPageViewModel.cs` (+15 -1) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Prevent application from crashing when uploading a file. ## Code changes * **AttachmentPageViewModel.cs:** Improved error handling and catching when saving an attachment ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:25 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3338
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?