github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-11 00:56:24 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #2071] [MERGED] [SG-659] Fixed TOTP not showing for free user with classic plans. #3333

New Issue
Closed
opened 2025-11-26 23:31:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2071
Author: @andrebispo5
Created: 9/14/2022
Status: ✅ Merged
Merged: 9/14/2022
Merged by: @andrebispo5

Base: master ← Head: hotfix/totp-classicplan-freeuser

📝 Commits (2)

  • cdb389c [SG-659] Fixed TOTP not showing for free user with classic plans.
  • d1d3e3e [SG-659] Ran code format

📊 Changes

2 files changed (+7 additions, -7 deletions)

View changed files

📝 src/App/Pages/Vault/CipherDetailsPageViewModel.cs (+2 -2)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+5 -5)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixed bug where free users with classic organizations plans were not able to see TOTP codes.

Code changes

Added org validation besides premium.

Screenshots

Screenshot 2022-09-14 at 11 28 36 Screenshot 2022-09-14 at 11 28 27 Screenshot 2022-09-14 at 11 28 21 Screenshot 2022-09-14 at 11 28 14 Screenshot 2022-09-14 at 11 28 04 Screenshot 2022-09-14 at 11 27 46 Screenshot 2022-09-14 at 11 27 37

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2071 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 9/14/2022 **Status:** ✅ Merged **Merged:** 9/14/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `hotfix/totp-classicplan-freeuser` --- ### 📝 Commits (2) - [`cdb389c`](https://github.com/bitwarden/android/commit/cdb389cac955d174cd2b9e0baa139e8dd74737e0) [SG-659] Fixed TOTP not showing for free user with classic plans. - [`d1d3e3e`](https://github.com/bitwarden/android/commit/d1d3e3edc45b8bd815e05afe87d3bbb638f27580) [SG-659] Ran code format ### 📊 Changes **2 files changed** (+7 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` (+2 -2) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+5 -5) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fixed bug where free users with classic organizations plans were not able to see TOTP codes. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Added org validation besides premium. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="369" alt="Screenshot 2022-09-14 at 11 28 36" src="https://user-images.githubusercontent.com/4648522/190131542-427af1f0-8dbc-419b-9c8c-937778d9d922.png"> <img width="374" alt="Screenshot 2022-09-14 at 11 28 27" src="https://user-images.githubusercontent.com/4648522/190131545-389e15b7-6a6f-43be-84b3-56243c5f2c67.png"> <img width="374" alt="Screenshot 2022-09-14 at 11 28 21" src="https://user-images.githubusercontent.com/4648522/190131555-2c9f11ab-697b-4c23-83ce-e994d162af7f.png"> <img width="380" alt="Screenshot 2022-09-14 at 11 28 14" src="https://user-images.githubusercontent.com/4648522/190131561-90cbb52a-5a8c-4031-b588-d5fafc5ff9d6.png"> <img width="380" alt="Screenshot 2022-09-14 at 11 28 04" src="https://user-images.githubusercontent.com/4648522/190131568-ff3826c9-5b31-46c4-9d7b-59c98fbf9a66.png"> <img width="394" alt="Screenshot 2022-09-14 at 11 27 46" src="https://user-images.githubusercontent.com/4648522/190131573-7b76c397-b66e-4f71-8a87-efbcad6a1f18.png"> <img width="378" alt="Screenshot 2022-09-14 at 11 27 37" src="https://user-images.githubusercontent.com/4648522/190131577-73c6387d-950c-4372-b7c5-c1a7122ce0cd.png"> ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3333
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?