github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 12:32:53 -05:00
Code Issues 144 Packages Projects Releases 93 Wiki Activity

[PR #2055] [MERGED] [SG-408] Implement passwordless api methods #3325

New Issue
Closed
opened 2025-11-26 23:31:15 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:15 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2055
Author: @andrebispo5
Created: 8/30/2022
Status: ✅ Merged
Merged: 8/30/2022
Merged by: @andrebispo5

Base: feature/feature-passwordless-login ← Head: feature/passwordless-login-api-methods

📝 Commits (7)

  • f5caeea [SG-408] Update notification model.
  • 7d2d016 [SG-408] removed duplicated resource
  • 29ce1ca [SG-408] Added implementation to Api Service of new passwordless methods.
  • ef611ff removed qa endpoints
  • ebc3618 [SG-408] Changed auth methods implementation, added method call to viewmodel.
  • c466153 [SG-408] ran code format
  • 9782a5c [SG-408] PR fixes

📊 Changes

10 files changed (+109 additions, -35 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs (+1 -3)
📝 src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+19 -23)
📝 src/App/Resources/AppResources.resx (+0 -3)
📝 src/Core/Abstractions/IApiService.cs (+3 -0)
📝 src/Core/Abstractions/IAuthService.cs (+3 -3)
📝 src/Core/Enums/NotificationType.cs (+7 -0)
➕ src/Core/Models/Request/PasswordlessLoginRequest.cs (+21 -0)
➕ src/Core/Models/Response/PasswordlessLoginResponse.cs (+24 -0)
📝 src/Core/Services/ApiService.cs (+15 -0)
📝 src/Core/Services/AuthService.cs (+16 -3)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Code changes

Added two method to connect to api service, one to get the details from a passwordless request and another to accept/reject a pending request.

Before you submit

  • Please check for formatting errors (dotnet format --verify-no-changes) (required)
  • Please add unit tests where it makes sense to do so (encouraged but not required)
  • If this change requires a documentation update - notify the documentation team
  • If this change has particular deployment requirements - notify the DevOps team

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2055 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/30/2022 **Status:** ✅ Merged **Merged:** 8/30/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/feature-passwordless-login` ← **Head:** `feature/passwordless-login-api-methods` --- ### 📝 Commits (7) - [`f5caeea`](https://github.com/bitwarden/android/commit/f5caeeaa68156faa493b4fd6c786fdfa2663451c) [SG-408] Update notification model. - [`7d2d016`](https://github.com/bitwarden/android/commit/7d2d0161b2a8e29f42d84487b533b5c08a1dc6fd) [SG-408] removed duplicated resource - [`29ce1ca`](https://github.com/bitwarden/android/commit/29ce1caf4b74dffb349a2d7d8352db7ee926cf66) [SG-408] Added implementation to Api Service of new passwordless methods. - [`ef611ff`](https://github.com/bitwarden/android/commit/ef611ff4ab8010d271f149a7643063d5920ff4fb) removed qa endpoints - [`ebc3618`](https://github.com/bitwarden/android/commit/ebc36181bfb8b2c0adf91ce97a31384d012612e8) [SG-408] Changed auth methods implementation, added method call to viewmodel. - [`c466153`](https://github.com/bitwarden/android/commit/c4661537c91a87f48ee684ba652263ba89bb5ae3) [SG-408] ran code format - [`9782a5c`](https://github.com/bitwarden/android/commit/9782a5c69e206325008ca7a72fce29a5f6d4c0f6) [SG-408] PR fixes ### 📊 Changes **10 files changed** (+109 additions, -35 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs` (+1 -3) 📝 `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+19 -23) 📝 `src/App/Resources/AppResources.resx` (+0 -3) 📝 `src/Core/Abstractions/IApiService.cs` (+3 -0) 📝 `src/Core/Abstractions/IAuthService.cs` (+3 -3) 📝 `src/Core/Enums/NotificationType.cs` (+7 -0) ➕ `src/Core/Models/Request/PasswordlessLoginRequest.cs` (+21 -0) ➕ `src/Core/Models/Response/PasswordlessLoginResponse.cs` (+24 -0) 📝 `src/Core/Services/ApiService.cs` (+15 -0) 📝 `src/Core/Services/AuthService.cs` (+16 -3) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> Added two method to connect to api service, one to get the details from a passwordless request and another to accept/reject a pending request. ## Before you submit - Please check for formatting errors (`dotnet format --verify-no-changes`) (required) - Please add **unit tests** where it makes sense to do so (encouraged but not required) - If this change requires a **documentation update** - notify the documentation team - If this change has particular **deployment requirements** - notify the DevOps team --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:15 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3325
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?