github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-21 22:00:42 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2053] [MERGED] [PS-191] Improve support for larger fonts Android #3323

New Issue
Closed
opened 2025-11-26 23:31:13 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:13 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2053
Author: @aj-rosado
Created: 8/29/2022
Status: ✅ Merged
Merged: 8/31/2022
Merged by: @aj-rosado

Base: master ← Head: feature/PS-191-Add-support-larger-fonts-android

📝 Commits (2)

  • 401f6e5 PS-191 Removed android native font scaling
  • 40520d4 PS-191 Added exception handling when disabling android font scale

📊 Changes

1 file changed (+21 additions, -2 deletions)

View changed files

📝 src/Android/MainActivity.cs (+21 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

The fonts on Android are too big on some devices. Removed Android native scaling as xamarin NamedSize is already scaling the fonts.

Code changes

  • MainActivity.cs: Set the native Android font scaling to 1. So that it doesn't scale as the Xamarin NamedSize is already scaling the text

Screenshots

Max font size with Android scaling:
scaling

Max font size without Android scaling:
no-scaling

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2053 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 8/29/2022 **Status:** ✅ Merged **Merged:** 8/31/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `feature/PS-191-Add-support-larger-fonts-android` --- ### 📝 Commits (2) - [`401f6e5`](https://github.com/bitwarden/android/commit/401f6e54bff212a847f8eb6192ba15bad1b7a2b0) PS-191 Removed android native font scaling - [`40520d4`](https://github.com/bitwarden/android/commit/40520d4e79b1a9625dc78f0efcf1b9f31d448d57) PS-191 Added exception handling when disabling android font scale ### 📊 Changes **1 file changed** (+21 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/MainActivity.cs` (+21 -2) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective The fonts on Android are too big on some devices. Removed Android native scaling as xamarin `NamedSize` is already scaling the fonts. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **MainActivity.cs:** Set the native Android font scaling to 1. So that it doesn't scale as the Xamarin `NamedSize` is already scaling the text ## Screenshots Max font size with Android scaling: ![scaling](https://user-images.githubusercontent.com/109146700/187218925-85d3913f-ba2d-477a-9edf-966053e4571c.jpeg) Max font size without Android scaling: ![no-scaling](https://user-images.githubusercontent.com/109146700/187218942-09015e54-a14a-4e18-84d0-bcd572f9d8bd.jpeg) ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:13 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3323
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?