github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-19 05:02:48 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2041] [MERGED] [SG-416] Updates to Bitwarden Authenticator (Feature Branch) #3314

New Issue
Closed
opened 2025-11-26 23:31:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2041
Author: @andrebispo5
Created: 8/17/2022
Status: ✅ Merged
Merged: 8/17/2022
Merged by: @andrebispo5

Base: master ← Head: feature/feature-totp

📝 Commits (10+)

  • b02c58e Initial commit of new TOTP page
  • bb37bac Revert config files from previous commit
  • 98dd829 clear extra code and fix build
  • 0ad992f add tab page
  • 26e0e43 Merge branch 'master' into beeep-totp
  • 008ed8e add authentication view cell
  • 3ac2580 add toolbar icons
  • 0b626ce got the countdown working
  • 655b51b Merge branch 'master' into beeep-totp
  • 31d1a2e enable context loading and vm init

📊 Changes

30 files changed (+1412 additions, -168 deletions)

View changed files

📝 src/Android/Properties/AndroidManifest.xml (+1 -0)
➕ src/App/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml (+127 -0)
➕ src/App/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml.cs (+67 -0)
➕ src/App/Controls/CircularProgressbarView.cs (+139 -0)
📝 src/App/Pages/Vault/CipherAddEditPage.xaml (+32 -2)
📝 src/App/Pages/Vault/CipherAddEditPageViewModel.cs (+21 -1)
📝 src/App/Pages/Vault/CipherDetailsPage.xaml (+51 -30)
📝 src/App/Pages/Vault/CipherDetailsPage.xaml.cs (+1 -1)
📝 src/App/Pages/Vault/CipherDetailsPageViewModel.cs (+42 -21)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml (+10 -1)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs (+51 -28)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListGroup.cs (+3 -3)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs (+9 -0)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageListItemSelector.cs (+7 -0)
➕ src/App/Pages/Vault/GroupingsPage/GroupingsPageTOTPListItem.cs (+123 -0)
📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+91 -8)
📝 src/App/Pages/Vault/ScanPage.xaml (+107 -47)
📝 src/App/Pages/Vault/ScanPage.xaml.cs (+159 -12)
➕ src/App/Pages/Vault/ScanPageViewModel.cs (+61 -0)
📝 src/App/Resources/AppResources.Designer.cs (+80 -8)

...and 10 more files

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Feature branch containing all reviewed PRs from the updates to Bitwarden authenticator:
https://github.com/bitwarden/mobile/pull/1964
https://github.com/bitwarden/mobile/pull/2027

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2041 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 8/17/2022 **Status:** ✅ Merged **Merged:** 8/17/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `feature/feature-totp` --- ### 📝 Commits (10+) - [`b02c58e`](https://github.com/bitwarden/android/commit/b02c58e3623781ada1e9e8f820b403a5c48274aa) Initial commit of new TOTP page - [`bb37bac`](https://github.com/bitwarden/android/commit/bb37bac620e99ec6a117170e64015edecf37d39d) Revert config files from previous commit - [`98dd829`](https://github.com/bitwarden/android/commit/98dd8298ea920e25b45938f805b005b5c70158e9) clear extra code and fix build - [`0ad992f`](https://github.com/bitwarden/android/commit/0ad992faeca1480b25524371bed5195520f1f2db) add tab page - [`26e0e43`](https://github.com/bitwarden/android/commit/26e0e43bb47df9685fcbbda8df6f6e9bc2e0f24a) Merge branch 'master' into beeep-totp - [`008ed8e`](https://github.com/bitwarden/android/commit/008ed8eb56cf273d04037df5da57264eb22cfb25) add authentication view cell - [`3ac2580`](https://github.com/bitwarden/android/commit/3ac2580742bb9862490dc6e709cae6753054d7d0) add toolbar icons - [`0b626ce`](https://github.com/bitwarden/android/commit/0b626cedc7405ab7a20950159bd6b13f9a1202e3) got the countdown working - [`655b51b`](https://github.com/bitwarden/android/commit/655b51b6a585754d90aca1a3ff85973047dc3cde) Merge branch 'master' into beeep-totp - [`31d1a2e`](https://github.com/bitwarden/android/commit/31d1a2e083a58a1a503c6435ee0b08fd192e517b) enable context loading and vm init ### 📊 Changes **30 files changed** (+1412 additions, -168 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Properties/AndroidManifest.xml` (+1 -0) ➕ `src/App/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml` (+127 -0) ➕ `src/App/Controls/AuthenticatorViewCell/AuthenticatorViewCell.xaml.cs` (+67 -0) ➕ `src/App/Controls/CircularProgressbarView.cs` (+139 -0) 📝 `src/App/Pages/Vault/CipherAddEditPage.xaml` (+32 -2) 📝 `src/App/Pages/Vault/CipherAddEditPageViewModel.cs` (+21 -1) 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml` (+51 -30) 📝 `src/App/Pages/Vault/CipherDetailsPage.xaml.cs` (+1 -1) 📝 `src/App/Pages/Vault/CipherDetailsPageViewModel.cs` (+42 -21) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml` (+10 -1) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPage.xaml.cs` (+51 -28) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListGroup.cs` (+3 -3) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListItem.cs` (+9 -0) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageListItemSelector.cs` (+7 -0) ➕ `src/App/Pages/Vault/GroupingsPage/GroupingsPageTOTPListItem.cs` (+123 -0) 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+91 -8) 📝 `src/App/Pages/Vault/ScanPage.xaml` (+107 -47) 📝 `src/App/Pages/Vault/ScanPage.xaml.cs` (+159 -12) ➕ `src/App/Pages/Vault/ScanPageViewModel.cs` (+61 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+80 -8) _...and 10 more files_ </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Feature branch containing all reviewed PRs from the updates to Bitwarden authenticator: https://github.com/bitwarden/mobile/pull/1964 https://github.com/bitwarden/mobile/pull/2027 ## Before you submit - [ ] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3314
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?