github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-17 01:31:08 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2038] [MERGED] [PS-1009] Changed keyboard on Passphrase generator to not allow emojis #3311

New Issue
Closed
opened 2025-11-26 23:31:04 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:31:04 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2038
Author: @aj-rosado
Created: 8/15/2022
Status: ✅ Merged
Merged: 8/16/2022
Merged by: @aj-rosado

Base: master ← Head: bug/PS-1009-removed-emojis-from-passphrase-generator-keyboard

📝 Commits (5)

  • 26aca57 PS-1009 Added effect to Entry that doesn't allow keyboard with emojis on passphrase separator
  • 67ad32f PS-1009 Removed unnecessary ImeOptions setting from NoEmojiKeyboardEffect
  • 728b8d1 Merge branch 'master' into bug/PS-1009-removed-emojis-from-passphrase-generator-keyboard
  • 1d39717 PS-1009 Removed unnecessary null validation on Android's NoEmojiKeyboardEffect
  • faf722d Merge branch 'master' into bug/PS-1009-removed-emojis-from-passphrase-generator-keyboard

📊 Changes

6 files changed (+69 additions, -1 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -0)
➕ src/Android/Effects/NoEmojiKeyboardEffect.cs (+24 -0)
➕ src/App/Effects/NoEmojiKeyboardEffect.cs (+12 -0)
📝 src/App/Pages/Generator/GeneratorPage.xaml (+6 -1)
➕ src/iOS.Core/Effects/NoEmojiKeyboardEffect.cs (+25 -0)
📝 src/iOS.Core/iOS.Core.csproj (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Remove the possibility of adding emojis on the word separator at Generator when passphrase is selected

Code changes

  • NoEmojiKeyboardEffect.cs: Created effect with settings to not show emojis on the keyboard, both on iOS and Android.
  • GeneratorPage.cs: Added NoEmojiKeyboardEffect to the passphrase generator Entry

Screenshots

Screenshot_1660582307
Simulator Screen Shot - iPhone 11 Pro Max - 2022-08-15 at 17 52 36

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2038 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 8/15/2022 **Status:** ✅ Merged **Merged:** 8/16/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `bug/PS-1009-removed-emojis-from-passphrase-generator-keyboard` --- ### 📝 Commits (5) - [`26aca57`](https://github.com/bitwarden/android/commit/26aca5730892758bafa36a67fbc56c7592ac3108) PS-1009 Added effect to Entry that doesn't allow keyboard with emojis on passphrase separator - [`67ad32f`](https://github.com/bitwarden/android/commit/67ad32f75dec4ebb4f401ce9156f13c85ef72f8f) PS-1009 Removed unnecessary ImeOptions setting from NoEmojiKeyboardEffect - [`728b8d1`](https://github.com/bitwarden/android/commit/728b8d1e698a3fa743f353ffde2fdc8b2970c172) Merge branch 'master' into bug/PS-1009-removed-emojis-from-passphrase-generator-keyboard - [`1d39717`](https://github.com/bitwarden/android/commit/1d39717050bd7f4d9e2e406ea9363949165917d0) PS-1009 Removed unnecessary null validation on Android's NoEmojiKeyboardEffect - [`faf722d`](https://github.com/bitwarden/android/commit/faf722da7111fd550107bb8ff4368db6a92818c8) Merge branch 'master' into bug/PS-1009-removed-emojis-from-passphrase-generator-keyboard ### 📊 Changes **6 files changed** (+69 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -0) ➕ `src/Android/Effects/NoEmojiKeyboardEffect.cs` (+24 -0) ➕ `src/App/Effects/NoEmojiKeyboardEffect.cs` (+12 -0) 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+6 -1) ➕ `src/iOS.Core/Effects/NoEmojiKeyboardEffect.cs` (+25 -0) 📝 `src/iOS.Core/iOS.Core.csproj` (+1 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Remove the possibility of adding emojis on the word separator at Generator when passphrase is selected ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **NoEmojiKeyboardEffect.cs:** Created effect with settings to not show emojis on the keyboard, both on iOS and Android. * **GeneratorPage.cs:** Added NoEmojiKeyboardEffect to the passphrase generator Entry ## Screenshots ![Screenshot_1660582307](https://user-images.githubusercontent.com/109146700/184679702-17835507-d6c0-4aea-8fd8-2cb92e57ef18.png) ![Simulator Screen Shot - iPhone 11 Pro Max - 2022-08-15 at 17 52 36](https://user-images.githubusercontent.com/109146700/184679714-87b4984e-238e-4e34-bbba-f2357f48f8b1.png) ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:31:04 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3311
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?