github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #689] [MERGED] Fix for notification pendingIntent uri being set to browser package name #33047

New Issue
Closed
opened 2026-04-21 00:54:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-21 00:54:32 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/689
Author: @mpbw2
Created: 1/3/2020
Status: ✅ Merged
Merged: 1/3/2020
Merged by: @kspearrin

Base: master ← Head: bugfix-accessibility

📝 Commits (1)

  • ad8e25b * AccessibilityHelpers.cs: If

📊 Changes

2 files changed (+8 additions, -2 deletions)

View changed files

📝 src/Android/Accessibility/AccessibilityHelpers.cs (+6 -0)
📝 src/Android/Accessibility/AccessibilityService.cs (+2 -2)

📄 Description

  • AccessibilityHelpers.cs: If AccessibilityNodeInfo.FindAccessibilityNodeInfosByViewId(..) returns null when the source package is a supported browser, return a null uri to prevent overwriting the existing notification's pendingIntent uri extra with the brower's packageName.

  • AccessibilityService.cs: Added null uri checks as it is now possible for AccessibilityHelpers.getUri(..) to return a null uri when the Accessibility Service is misbehaving.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/689 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 1/3/2020 **Status:** ✅ Merged **Merged:** 1/3/2020 **Merged by:** [@kspearrin](https://github.com/kspearrin) **Base:** `master` ← **Head:** `bugfix-accessibility` --- ### 📝 Commits (1) - [`ad8e25b`](https://github.com/bitwarden/android/commit/ad8e25b01d84cafbce9d74d4deda0e2ec9a09172) * AccessibilityHelpers.cs: If ### 📊 Changes **2 files changed** (+8 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Accessibility/AccessibilityHelpers.cs` (+6 -0) 📝 `src/Android/Accessibility/AccessibilityService.cs` (+2 -2) </details> ### 📄 Description * AccessibilityHelpers.cs: If AccessibilityNodeInfo.FindAccessibilityNodeInfosByViewId(..) returns null when the source package is a supported browser, return a null uri to prevent overwriting the existing notification's pendingIntent uri extra with the brower's packageName. * AccessibilityService.cs: Added null uri checks as it is now possible for AccessibilityHelpers.getUri(..) to return a null uri when the Accessibility Service is misbehaving. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-21 00:54:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#33047
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?