github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-12 05:04:17 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[Android] Verify Pin keyboard should restrict the on-screen keyboard to the numeric input type. #330

New Issue
Closed
opened 2025-11-07 08:35:33 -06:00 by GiteaMirror · 4 comments
GiteaMirror commented 2025-11-07 08:35:33 -06:00
Owner
Copy Link

Originally created by @kvithayathil on GitHub (Jan 18, 2019).

As a usability/accessibility improvement - could the Verify Pin screen request the input type to be numberPassword (or Xamarin equivalent) so that the keyboard that appears is just nummeric digits?

I've attached an example to illustrate:

numpad-pin_bitwarden

Originally created by @kvithayathil on GitHub (Jan 18, 2019). <!-- Please do not submit feature requests. The [Community Forums][1] has a section for submitting, voting for, and discussing product feature requests. [1]: https://community.bitwarden.com --> As a usability/accessibility improvement - could the Verify Pin screen request the input type to be `numberPassword` (or Xamarin equivalent) so that the keyboard that appears is just nummeric digits? I've attached an example to illustrate: ![numpad-pin_bitwarden](https://user-images.githubusercontent.com/1056073/51398680-3986af00-1b12-11e9-94b1-e31c448a1609.png)
GiteaMirror added the enhancement label 2025-11-07 08:35:33 -06:00
GiteaMirror commented 2025-11-07 08:35:34 -06:00
Author
Owner
Copy Link

@devsecdan commented on GitHub (Jan 23, 2019):

The input method is already set to Keyboard.Numeric, which is the closest Xamarin equivalent to what you're asking for.

The exact form this takes depends on your keyboard. With the Samsung keyboard I get a layout similar to the one in your picture, but with Swiftkey there's a lot of additional symbols.

A way to make the input method consistent could be to make in-app buttons, similar to how Sync does it:

screenshot_2019-01-22-23-41-16

@devsecdan commented on GitHub (Jan 23, 2019): The input method is already set to Keyboard.Numeric, which is the closest Xamarin equivalent to what you're asking for. The exact form this takes depends on your keyboard. With the Samsung keyboard I get a layout similar to the one in your picture, but with Swiftkey there's a lot of additional symbols. A way to make the input method consistent could be to make in-app buttons, similar to how Sync does it: ![screenshot_2019-01-22-23-41-16](https://user-images.githubusercontent.com/6662937/51573682-43a60600-1ea2-11e9-8cc8-ef763e0c1440.png)
GiteaMirror commented 2025-11-07 08:35:34 -06:00
Author
Owner
Copy Link

@kvithayathil commented on GitHub (Jan 23, 2019):

Thanks for sharing @ShirokaiLon. I'm not familiar with the Xamarin options so that's interesting to know.

My device is actually a Note 9 running SwiftKey - which is what that picture is showing. 🤔

@kvithayathil commented on GitHub (Jan 23, 2019): Thanks for sharing @ShirokaiLon. I'm not familiar with the Xamarin options so that's interesting to know. My device is actually a Note 9 running SwiftKey - which is what that picture is showing. 🤔
GiteaMirror commented 2025-11-07 08:35:34 -06:00
Author
Owner
Copy Link

@devsecdan commented on GitHub (Jan 24, 2019):

You're quite right. It seems that Xamarin simply does not have a Keyboard option which triggers the numbers-only layout of SwiftKey.

The only way to solve this is to circumvent the Xamarin Keyboard settings and set the Android InputType directly:

screenshot_2019-01-24-17-50-54

I also compared how the Samsung keyboard changes:

Using Xamarin Keyboard.Numeric:
screenshot_2019-01-24-17-56-03

Setting the InputType directly:
screenshot_2019-01-24-17-53-53

So, I think the 'numberPassword' layout is better in general, but not being able to set it using the Xamarin Keyboard makes it slightly messier.

I'll create a pull request and let the powers that be decide 😁

@devsecdan commented on GitHub (Jan 24, 2019): You're quite right. It seems that Xamarin simply does not have a Keyboard option which triggers the numbers-only layout of SwiftKey. The only way to solve this is to circumvent the Xamarin Keyboard settings and set the Android InputType directly: ![screenshot_2019-01-24-17-50-54](https://user-images.githubusercontent.com/6662937/51698930-71ef2700-2003-11e9-819e-3b1dbc0ffbee.png) I also compared how the Samsung keyboard changes: Using Xamarin Keyboard.Numeric: ![screenshot_2019-01-24-17-56-03](https://user-images.githubusercontent.com/6662937/51698986-90552280-2003-11e9-859c-625f8d5708a4.png) Setting the InputType directly: ![screenshot_2019-01-24-17-53-53](https://user-images.githubusercontent.com/6662937/51699028-a7941000-2003-11e9-8f08-03e271e550d7.png) So, I think the 'numberPassword' layout is better in general, but not being able to set it using the Xamarin Keyboard makes it slightly messier. I'll create a pull request and let the powers that be decide 😁
GiteaMirror commented 2025-11-07 08:35:34 -06:00
Author
Owner
Copy Link

@kvithayathil commented on GitHub (Jan 25, 2019):

@ShirokaiLon Thank you - appreciate the rapid responses to this issue 👍

@kvithayathil commented on GitHub (Jan 25, 2019): @ShirokaiLon Thank you - appreciate the rapid responses to this issue 👍
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#330
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?