github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 23:58:32 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2021] [MERGED] [PS-1228] Android: Label of terms of service and privacy policy switch is too close to the actual switch in the sign-up screen #3297

New Issue
Closed
opened 2025-11-26 23:30:53 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:53 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2021
Author: @deividt
Created: 8/1/2022
Status: ✅ Merged
Merged: 8/16/2022
Merged by: @aj-rosado

Base: master ← Head: dg/bug/android-switch-is-too-close-to-the-switch-text-sign-up-page

📝 Commits (1)

  • 699aa15 Changed the right margin of the switch

📊 Changes

2 files changed (+1 additions, -9 deletions)

View changed files

📝 src/App/Pages/Accounts/RegisterPage.xaml (+1 -1)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+0 -8)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

This PR fixes the #2009 issue. It adds a margin between the switch and the privacy policy text in the sign-up screen.

Code changes

  • RegisterPage.xaml: Removed the binding property for the margin and changed to a fixed value. Since I haven't found any style for the switch, I kept the definition here.
  • RegisterPageViewModel.xaml: Since now the value is the same for iOS and Android, the property is no longer necessary.

Screenshots

Screenshot_1659324516

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2021 **Author:** [@deividt](https://github.com/deividt) **Created:** 8/1/2022 **Status:** ✅ Merged **Merged:** 8/16/2022 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `master` ← **Head:** `dg/bug/android-switch-is-too-close-to-the-switch-text-sign-up-page` --- ### 📝 Commits (1) - [`699aa15`](https://github.com/bitwarden/android/commit/699aa159dee6214758a4d9ebe12a1e2a83cfb623) Changed the right margin of the switch ### 📊 Changes **2 files changed** (+1 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+1 -1) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+0 -8) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective This PR fixes the #2009 issue. It adds a margin between the switch and the privacy policy text in the sign-up screen. ## Code changes * **RegisterPage.xaml:** Removed the binding property for the margin and changed to a fixed value. Since I haven't found any style for the switch, I kept the definition here. * **RegisterPageViewModel.xaml:** Since now the value is the same for iOS and Android, the property is no longer necessary. ## Screenshots ![Screenshot_1659324516](https://user-images.githubusercontent.com/4616241/182067006-3d4e075d-6f84-4453-a506-d74b8cc35406.png) ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:53 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3297
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?