github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #2017] [MERGED] [SG-471] Passwordless device login screen #3295

New Issue
Closed
opened 2025-11-26 23:30:51 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:51 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/2017
Author: @andrebispo5
Created: 7/28/2022
Status: ✅ Merged
Merged: 8/2/2022
Merged by: @andrebispo5

Base: feature/feature-passwordless-login ← Head: feature/passwordless-device-login-screen

📝 Commits (10+)

  • e52f527 [SSG-471] Added UI for the device login request response.
  • 4e0da8f [SG-471] Added text resources and arguments to Page.
  • 90fe9f8 [SG-471] Added properties to speed up page bindings
  • 7b237b4 [SG-471] Added mock services. Added Accept/reject command binding, navigation and toast messages.
  • 7ac6eeb Merge branch 'master' into feature/passwordless-device-login-screen
  • bf3df00 [SG-471] fixed code styling with dotnet-format
  • e3ed37b [SG-471] Fixed back button placement. PR fixes.
  • 0ee0b80 [SG-471] Added new Origin parameter to the page.
  • e498b9c [SG-471] PR Fixes
  • dae947f [SG-471] PR fixes

📊 Changes

9 files changed (+409 additions, -0 deletions)

View changed files

📝 src/App/App.csproj (+3 -0)
➕ src/App/Pages/Accounts/LoginPasswordlessPage.xaml (+86 -0)
➕ src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs (+33 -0)
➕ src/App/Pages/Accounts/LoginPasswordlessViewModel.cs (+157 -0)
📝 src/App/Resources/AppResources.Designer.cs (+78 -0)
📝 src/App/Resources/AppResources.resx (+42 -0)
📝 src/Core/Abstractions/IAuthService.cs (+5 -0)
📝 src/Core/Constants.cs (+1 -0)
📝 src/Core/Services/AuthService.cs (+4 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

  • Screen which the user will land after clicking remote notification for device login request
  • Screen will populate with information coming from the notification
  • Will need server endpoint to accept/reject the login request
  • Navigation to vault after accept/reject action
  • Show information toast after server response from action

Code changes

This PR is being merged into its feature branch in order to have smaller pull requests until we have the full feature to go to master.

  • src/App/Pages/Accounts/LoginPasswordlessViewModel.cs: AcceptRequestAsync() and RejectRequestAsync() methods have mock service calls, this may change in the future based on service requirements.
  • src/Core/Services/AuthService.cs: passwordless methods will be implemented in the future in another PR, for now they are has just mocks.

Screenshots

image image image image

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/2017 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 7/28/2022 **Status:** ✅ Merged **Merged:** 8/2/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `feature/feature-passwordless-login` ← **Head:** `feature/passwordless-device-login-screen` --- ### 📝 Commits (10+) - [`e52f527`](https://github.com/bitwarden/android/commit/e52f527eea4a025700bb86afdb9c421ba775f8bf) [SSG-471] Added UI for the device login request response. - [`4e0da8f`](https://github.com/bitwarden/android/commit/4e0da8fd9683ced32f8b8d04653b1cd7451061fe) [SG-471] Added text resources and arguments to Page. - [`90fe9f8`](https://github.com/bitwarden/android/commit/90fe9f8600caa98465068a172baffe9684e35147) [SG-471] Added properties to speed up page bindings - [`7b237b4`](https://github.com/bitwarden/android/commit/7b237b4efe454655429c891a221a75f067cfb70b) [SG-471] Added mock services. Added Accept/reject command binding, navigation and toast messages. - [`7ac6eeb`](https://github.com/bitwarden/android/commit/7ac6eeb5cfec6ebe07d822de44460d18599ba38f) Merge branch 'master' into feature/passwordless-device-login-screen - [`bf3df00`](https://github.com/bitwarden/android/commit/bf3df0099618ebf334c0ea20ce89876fa8c8201e) [SG-471] fixed code styling with dotnet-format - [`e3ed37b`](https://github.com/bitwarden/android/commit/e3ed37bc48775c6ff469a5eeada28fc8818bbecd) [SG-471] Fixed back button placement. PR fixes. - [`0ee0b80`](https://github.com/bitwarden/android/commit/0ee0b80246ea6e2b6e34faaf74ff08ea5b435660) [SG-471] Added new Origin parameter to the page. - [`e498b9c`](https://github.com/bitwarden/android/commit/e498b9c469f390112539ce170876a816966178a9) [SG-471] PR Fixes - [`dae947f`](https://github.com/bitwarden/android/commit/dae947f563e23d49e5d8f640f5407ef287c69c41) [SG-471] PR fixes ### 📊 Changes **9 files changed** (+409 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/App.csproj` (+3 -0) ➕ `src/App/Pages/Accounts/LoginPasswordlessPage.xaml` (+86 -0) ➕ `src/App/Pages/Accounts/LoginPasswordlessPage.xaml.cs` (+33 -0) ➕ `src/App/Pages/Accounts/LoginPasswordlessViewModel.cs` (+157 -0) 📝 `src/App/Resources/AppResources.Designer.cs` (+78 -0) 📝 `src/App/Resources/AppResources.resx` (+42 -0) 📝 `src/Core/Abstractions/IAuthService.cs` (+5 -0) 📝 `src/Core/Constants.cs` (+1 -0) 📝 `src/Core/Services/AuthService.cs` (+4 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective - Screen which the user will land after clicking remote notification for device login request - Screen will populate with information coming from the notification - Will need server endpoint to accept/reject the login request - Navigation to vault after accept/reject action - Show information toast after server response from action ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> This PR is being merged into its feature branch in order to have smaller pull requests until we have the full feature to go to master. <!--Also refer to any related changes or PRs in other repositories--> * **src/App/Pages/Accounts/LoginPasswordlessViewModel.cs:** `AcceptRequestAsync()` and `RejectRequestAsync()` methods have mock service calls, this may change in the future based on service requirements. * **src/Core/Services/AuthService.cs:** passwordless methods will be implemented in the future in another PR, for now they are has just mocks. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> <img width="391" alt="image" src="https://user-images.githubusercontent.com/4648522/181563282-d568d09d-91c7-4a10-b13b-8e11061a74f2.png"> <img width="389" alt="image" src="https://user-images.githubusercontent.com/4648522/181563537-e3f8c0da-0ba7-4f5a-8df7-7c8bf47c8c37.png"> <img width="407" alt="image" src="https://user-images.githubusercontent.com/4648522/181562625-2e05163e-ca94-41b8-a080-30e91b9d0f87.png"> <img width="398" alt="image" src="https://user-images.githubusercontent.com/4648522/181562835-e79a930a-257f-44ab-9deb-ce6e24bebf99.png"> ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:51 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3295
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?