github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6808] [MERGED] chore: Use private key accessor #32892

New Issue
Closed
opened 2026-04-18 16:14:30 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 16:14:30 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6808
Author: @david-livefront
Created: 4/17/2026
Status: ✅ Merged
Merged: 4/20/2026
Merged by: @david-livefront

Base: main ← Head: update-private-key

📝 Commits (1)

📊 Changes

6 files changed (+89 additions, -144 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt (+25 -96)
➕ app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/AccountKeysJsonExtensions.kt (+23 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt (+2 -11)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+2 -8)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt (+3 -10)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt (+34 -19)

📄 Description

🎟️ Tracking

NA

📔 Objective

This PR updates the way we access the private key from the login response to ensure we are always attempting to retrieve it from the accountKeys before falling back to the legacy privateKey property. Additionally, a new AccountKeysJson.toAccountCryptographicState extension was added to simplify the transformation to a WrappedAccountCryptographicState.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6808 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/17/2026 **Status:** ✅ Merged **Merged:** 4/20/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `update-private-key` --- ### 📝 Commits (1) - [`501c503`](https://github.com/bitwarden/android/commit/501c503b8dec06b7a03f52898ac835d524bc4e89) Use private key accessor ### 📊 Changes **6 files changed** (+89 additions, -144 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryImpl.kt` (+25 -96) ➕ `app/src/main/kotlin/com/x8bit/bitwarden/data/auth/repository/util/AccountKeysJsonExtensions.kt` (+23 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt` (+2 -11) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+2 -8) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/VaultRepositoryImpl.kt` (+3 -10) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/auth/repository/AuthRepositoryTest.kt` (+34 -19) </details> ### 📄 Description ## 🎟️ Tracking NA ## 📔 Objective This PR updates the way we access the private key from the login response to ensure we are always attempting to retrieve it from the `accountKeys` before falling back to the legacy `privateKey` property. Additionally, a new `AccountKeysJson.toAccountCryptographicState` extension was added to simplify the transformation to a `WrappedAccountCryptographicState`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 16:14:30 -05:00
GiteaMirror changed title from [PR #6808] chore: Use private key accessor to [PR #6808] [MERGED] chore: Use private key accessor 2026-04-21 04:26:23 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?