github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6792] [MERGED] Chore: Remove UI decisions based on portrait vs landscape #32880

New Issue
Closed
opened 2026-04-18 16:13:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 16:13:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6792
Author: @david-livefront
Created: 4/13/2026
Status: ✅ Merged
Merged: 4/17/2026
Merged by: @david-livefront

Base: main ← Head: remove-portait-checks

📝 Commits (1)

  • 9ab1651 Remove UI decisions based on portrait vs landscape

📊 Changes

3 files changed (+44 additions, -46 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt (+16 -12)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/tutorial/TutorialScreen.kt (+28 -19)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/util/ConfigurationExtensions.kt (+0 -15)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR removes the isPortrait checks from the Authenticator app and brings it inline with the Password Manager by using the window size to make the same determinations.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6792 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 4/13/2026 **Status:** ✅ Merged **Merged:** 4/17/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `remove-portait-checks` --- ### 📝 Commits (1) - [`9ab1651`](https://github.com/bitwarden/android/commit/9ab1651c9355ffd45df72ac1ddbd40ef0365c356) Remove UI decisions based on portrait vs landscape ### 📊 Changes **3 files changed** (+44 additions, -46 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/qrcodescan/QrCodeScanScreen.kt` (+16 -12) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/tutorial/TutorialScreen.kt` (+28 -19) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/util/ConfigurationExtensions.kt` (+0 -15) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR removes the `isPortrait` checks from the Authenticator app and brings it inline with the Password Manager by using the window size to make the same determinations. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 16:13:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32880
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?