github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 03:23:29 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6724] [MERGED] PM-34193: Rollback SDK update for Vault lockout bug #32830

New Issue
Closed
opened 2026-04-18 16:11:13 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 16:11:13 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6724
Author: @david-livefront
Created: 3/26/2026
Status: ✅ Merged
Merged: 3/27/2026
Merged by: @SaintPatrck

Base: release/2026.3-rc49 ← Head: PM-34193-vault-lockout

📝 Commits (1)

  • 150d671 PM-34193: Rollback SDK update for Vault lockout bug

📊 Changes

6 files changed (+1 additions, -228 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt (+0 -5)
➖ app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepository.kt (+0 -49)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+0 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/InitUserCryptoMethodExtensions.kt (+0 -1)
➖ app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepositoryTest.kt (+0 -171)
📝 gradle/libs.versions.toml (+1 -1)

📄 Description

🎟️ Tracking

PM-34193

📔 Objective

This PR addresses a bug with Never timeout value. When set, the app attempts to unlock the vault upon startup and fails due to a bug in the Bitwarden SDK. The SDK will never return from this attempt to unlock the vault and make it impossible to unlock with other means as well.

The main change is the rollback of the SDK.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6724 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 3/26/2026 **Status:** ✅ Merged **Merged:** 3/27/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `release/2026.3-rc49` ← **Head:** `PM-34193-vault-lockout` --- ### 📝 Commits (1) - [`150d671`](https://github.com/bitwarden/android/commit/150d671e9dd218d5e001c68e8b2c001da27305bb) PM-34193: Rollback SDK update for Vault lockout bug ### 📊 Changes **6 files changed** (+1 additions, -228 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/SdkRepositoryFactoryImpl.kt` (+0 -5) ➖ `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepository.kt` (+0 -49) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+0 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/repository/util/InitUserCryptoMethodExtensions.kt` (+0 -1) ➖ `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkLocalUserDataKeyStateRepositoryTest.kt` (+0 -171) 📝 `gradle/libs.versions.toml` (+1 -1) </details> ### 📄 Description ## 🎟️ Tracking [PM-34193](https://bitwarden.atlassian.net/browse/PM-34193) ## 📔 Objective This PR addresses a bug with `Never` timeout value. When set, the app attempts to unlock the vault upon startup and fails due to a bug in the Bitwarden SDK. The SDK will never return from this attempt to unlock the vault and make it impossible to unlock with other means as well. The main change is the rollback of the SDK. [PM-34193]: https://bitwarden.atlassian.net/browse/PM-34193?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 16:11:13 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32830
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?