github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-14 14:16:23 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1999] [MERGED] [SG-467] Fix environment url validations #3283

New Issue
Closed
opened 2025-11-26 23:30:42 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:42 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1999
Author: @LRNcardozoWDF
Created: 7/20/2022
Status: ✅ Merged
Merged: 7/20/2022
Merged by: @LRNcardozoWDF

Base: master ← Head: bug/SG-467-error-when-saving-environment-url-without-https

📝 Commits (2)

  • d9e4512 [SG-467] Fixed url validation so it works with or without http or https
  • cc3001b [SG-467] Validation has been refactored for simplicity.

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 src/App/Pages/Accounts/EnvironmentPageViewModel.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixed the validation of environment urls in Environment Settings page to also validate URLs without http:// or https:// allowing the successful saving of URLs with and without http:// or https:// .

Code changes

src/App/Pages/Accounts/EnvironmentPageViewModel.cs: Fixed validation from checking if URL is UriKind.Absolute to check if URL is UriKind.RelativeOrAbsolute.

Screenshots

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1999 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 7/20/2022 **Status:** ✅ Merged **Merged:** 7/20/2022 **Merged by:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Base:** `master` ← **Head:** `bug/SG-467-error-when-saving-environment-url-without-https` --- ### 📝 Commits (2) - [`d9e4512`](https://github.com/bitwarden/android/commit/d9e451277dd2bd902872bfb058f8c37062a26f7b) [SG-467] Fixed url validation so it works with or without http or https - [`cc3001b`](https://github.com/bitwarden/android/commit/cc3001b825d61380a9e26af1e50d8a5195c8cfb3) [SG-467] Validation has been refactored for simplicity. ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/EnvironmentPageViewModel.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fixed the validation of environment urls in Environment Settings page to also validate URLs without http:// or https:// allowing the successful saving of URLs with and without http:// or https:// . ## Code changes **src/App/Pages/Accounts/EnvironmentPageViewModel.cs**: Fixed validation from checking if URL is UriKind.Absolute to check if URL is UriKind.RelativeOrAbsolute. ## Screenshots ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:42 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3283
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?