github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6685] [MERGED] llm: Clarify @Suppress("MaxLineLength") usage in testing skill #32794

New Issue
Closed
opened 2026-04-18 16:09:38 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 16:09:38 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6685
Author: @SaintPatrck
Created: 3/17/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @SaintPatrck

Base: main ← Head: cx/fix-suppress-max-line-length-in-testing-skill

📝 Commits (2)

  • a5fc128 chore: Clarify @Suppress("MaxLineLength") usage in testing skill
  • 15bdf6d Update guidelines for @Suppress annotation usage

📊 Changes

1 file changed (+1 additions, -0 deletions)

View changed files

📝 .claude/skills/testing-android-code/SKILL.md (+1 -0)

📄 Description

🎟️ Tracking

No Jira ticket — Claude Code tooling improvement.

📔 Objective

Many existing test files use @Suppress("MaxLineLength") on test functions where the fun declaration does not actually exceed the 100 character line limit. This adds explicit guidance to the testing-android-code skill to prevent blindly copying the pattern from existing tests.

The rule: only add @Suppress("MaxLineLength") when the fun declaration line actually exceeds 100 characters.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6685 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/17/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `cx/fix-suppress-max-line-length-in-testing-skill` --- ### 📝 Commits (2) - [`a5fc128`](https://github.com/bitwarden/android/commit/a5fc128297898aac968ab22149b918482a2d24f7) chore: Clarify @Suppress("MaxLineLength") usage in testing skill - [`15bdf6d`](https://github.com/bitwarden/android/commit/15bdf6db90c037be0be68149777cf4c993ba99cc) Update guidelines for @Suppress annotation usage ### 📊 Changes **1 file changed** (+1 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `.claude/skills/testing-android-code/SKILL.md` (+1 -0) </details> ### 📄 Description ## 🎟️ Tracking No Jira ticket — Claude Code tooling improvement. ## 📔 Objective Many existing test files use `@Suppress("MaxLineLength")` on test functions where the `fun` declaration does not actually exceed the 100 character line limit. This adds explicit guidance to the `testing-android-code` skill to prevent blindly copying the pattern from existing tests. The rule: only add `@Suppress("MaxLineLength")` when the `fun` declaration line **actually exceeds 100 characters**. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 16:09:38 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32794