github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-06-10 00:28:29 -05:00
Code Issues 2.2k Packages Projects Releases 127 Wiki Activity

[PR #1993] [MERGED] [EC-324] Added more logging for information on list crash #3279

New Issue
Closed
opened 2025-11-26 23:30:39 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:39 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1993
Author: @fedemkr
Created: 7/14/2022
Status: ✅ Merged
Merged: 7/14/2022
Merged by: @vvolkgang

Base: master ← Head: EC-324-add-logging-list-ex-out-range

📝 Commits (2)

  • 5d30eb2 EC-324 Added more logging for trying to get more information on list out of range crash on AppCenter
  • de4b5dd EC-324 Fix include on iOS.Core.csproj on iOS CollectionView files

📊 Changes

4 files changed (+79 additions, -1 deletions)

View changed files

➕ src/iOS.Core/Renderers/CollectionView/CollectionException.cs (+16 -0)
📝 src/iOS.Core/Renderers/CollectionView/ExtendedGroupableItemsViewController.cs (+18 -1)
➕ src/iOS.Core/Renderers/CollectionView/ExtendedGroupableItemsViewDelegator.cs (+43 -0)
📝 src/iOS.Core/iOS.Core.csproj (+2 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Add more logging information to see where the AppCenter list crash is happening

Code changes

  • CollectionException.cs: Added this exception to easily spot it on the reports
  • ExtendedGroupableItemsViewController.cs: Improved the logging add creates the delegator
  • ExtendedGroupableItemsViewDelegator.cs: Added this delegator that is a point where we can add helpful logging of the crash

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1993 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/14/2022 **Status:** ✅ Merged **Merged:** 7/14/2022 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `master` ← **Head:** `EC-324-add-logging-list-ex-out-range` --- ### 📝 Commits (2) - [`5d30eb2`](https://github.com/bitwarden/android/commit/5d30eb2b87e39ba0adba51176873d9888ce17671) EC-324 Added more logging for trying to get more information on list out of range crash on AppCenter - [`de4b5dd`](https://github.com/bitwarden/android/commit/de4b5dd46a5dd67711584e95c9f120f3204de25b) EC-324 Fix include on iOS.Core.csproj on iOS CollectionView files ### 📊 Changes **4 files changed** (+79 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `src/iOS.Core/Renderers/CollectionView/CollectionException.cs` (+16 -0) 📝 `src/iOS.Core/Renderers/CollectionView/ExtendedGroupableItemsViewController.cs` (+18 -1) ➕ `src/iOS.Core/Renderers/CollectionView/ExtendedGroupableItemsViewDelegator.cs` (+43 -0) 📝 `src/iOS.Core/iOS.Core.csproj` (+2 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [X] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Add more logging information to see where the AppCenter list crash is happening ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **CollectionException.cs:** Added this exception to easily spot it on the reports * **ExtendedGroupableItemsViewController.cs:** Improved the logging add creates the delegator * **ExtendedGroupableItemsViewDelegator.cs:** Added this delegator that is a point where we can add helpful logging of the crash ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:39 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3279
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?