github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 11:56:35 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #1992] [MERGED] Add version change check in the version bump workflow #3278

New Issue
Closed
opened 2025-11-26 23:30:38 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:38 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1992
Author: @michalchecinski
Created: 7/14/2022
Status: ✅ Merged
Merged: 7/15/2022
Merged by: @michalchecinski

Base: master ← Head: DEVOPS-872_version_bump_not_fail

📝 Commits (1)

  • a815895 Add version change check in the version bump workflow

📊 Changes

1 file changed (+17 additions, -7 deletions)

View changed files

📝 .github/workflows/version-bump.yml (+17 -7)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Change the version bump workflow. If the project version already matches what is trying to be bumped to, quit the pipeline successfully. Workflow checks if there is anything to commit after running the script to update the version. If not, it skips PR with version bump creation.

JIRA task: https://bitwarden.atlassian.net/browse/DEVOPS-872

Code changes

  • .github/workflows/version-bump.yml: Add git status check to determine if any file changed on a version bump. Delete version bump branch checkout step as it's already done with git switch command.

Screenshots

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1992 **Author:** [@michalchecinski](https://github.com/michalchecinski) **Created:** 7/14/2022 **Status:** ✅ Merged **Merged:** 7/15/2022 **Merged by:** [@michalchecinski](https://github.com/michalchecinski) **Base:** `master` ← **Head:** `DEVOPS-872_version_bump_not_fail` --- ### 📝 Commits (1) - [`a815895`](https://github.com/bitwarden/android/commit/a815895176c3dd1a75dfe5110af72a50712a48c8) Add version change check in the version bump workflow ### 📊 Changes **1 file changed** (+17 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/version-bump.yml` (+17 -7) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [x] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Change the version bump workflow. If the project version already matches what is trying to be bumped to, quit the pipeline successfully. Workflow checks if there is anything to commit after running the script to update the version. If not, it skips PR with version bump creation. JIRA task: https://bitwarden.atlassian.net/browse/DEVOPS-872 ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **.github/workflows/version-bump.yml:** Add git status check to determine if any file changed on a version bump. Delete version bump branch checkout step as it's already done with git switch command. ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - [ ] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:38 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3278
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?