github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-08-16 15:09:35 -05:00
Code Issues 2.4k Packages Projects Releases 129 Wiki Activity

[PR #6665] [MERGED] llm: Add /review-android command and align reviewing-changes skill with agent #32775

New Issue
Closed
opened 2026-04-18 16:08:32 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 16:08:32 -05:00
Owner
Copy Link
Copy Source

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6665
Author: @SaintPatrck
Created: 3/13/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @theMickster

Base: main ← Head: tooling/improve-review-workflow

📝 Commits (2)

  • 6e62c12 llm: Add /review-android command and align reviewing-changes with agent
  • fd5e2db Update question emoji in code review documentation

📊 Changes

12 files changed (+124 additions, -375 deletions)

View changed files

📝 .claude/CLAUDE.md (+7 -8)
➕ .claude/commands/review-android.md (+72 -0)
📝 .claude/skills/reviewing-changes/SKILL.md (+8 -26)
📝 .claude/skills/reviewing-changes/checklists/bug-fix.md (+1 -28)
📝 .claude/skills/reviewing-changes/checklists/dependency-update.md (+1 -28)
📝 .claude/skills/reviewing-changes/checklists/feature-addition.md (+7 -176)
📝 .claude/skills/reviewing-changes/checklists/infrastructure.md (+1 -28)
📝 .claude/skills/reviewing-changes/checklists/refactoring.md (+1 -28)
📝 .claude/skills/reviewing-changes/checklists/ui-refinement.md (+1 -28)
📝 .claude/skills/reviewing-changes/examples/review-outputs.md (+19 -6)
📝 .claude/skills/reviewing-changes/reference/priority-framework.md (+6 -7)
📝 .claude/skills/reviewing-changes/reference/review-psychology.md (+0 -12)

📄 Description

🎟️ Tracking

LLM tooling improvement — no Jira ticket.

📔 Objective

Adds a /review-android slash command and aligns the reviewing-changes skill with the bitwarden-code-reviewer marketplace agent to eliminate contradictions and redundant content.

New command:

  • .claude/commands/review-android.md — 3-phase orchestrator (Ingest PR context → Android-specific review → Output findings) following the same pattern as /plan-android-work and /work-on-android

Skill improvements (reviewing-changes):

  • Removes redundant <thinking> blocks from SKILL.md body and duplicate output format sections from all 6 checklist files
  • Aligns summary format with the agent's posting-review-summary skill (adds <details> wrapper, surfaces critical issues above fold)
  • Fixes QUESTION emoji (💭 → ❓) to match the agent's classifying-review-findings skill
  • Tightens SUGGESTED criteria to require measurability (removes vague style/naming suggestions)
  • Adds priority ordering, Android-specific metadata checks (screenshots for Compose UI changes), and re-review guidance to SKILL.md
  • Removes Core Directives from review-psychology.md (fully covered by agent standards, no Android-specific value)
  • Collapses the 140-line inline architecture section in feature-addition.md to 4 bullets + reference pointer
  • Updates CLAUDE.md workflow skills list and quick reference

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6665 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 3/13/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@theMickster](https://github.com/theMickster) **Base:** `main` ← **Head:** `tooling/improve-review-workflow` --- ### 📝 Commits (2) - [`6e62c12`](https://github.com/bitwarden/android/commit/6e62c1265906aa67cbc1362c606f2794453b386d) llm: Add /review-android command and align reviewing-changes with agent - [`fd5e2db`](https://github.com/bitwarden/android/commit/fd5e2db146c747e84cebf069a37dcd671f1c9238) Update question emoji in code review documentation ### 📊 Changes **12 files changed** (+124 additions, -375 deletions) <details> <summary>View changed files</summary> 📝 `.claude/CLAUDE.md` (+7 -8) ➕ `.claude/commands/review-android.md` (+72 -0) 📝 `.claude/skills/reviewing-changes/SKILL.md` (+8 -26) 📝 `.claude/skills/reviewing-changes/checklists/bug-fix.md` (+1 -28) 📝 `.claude/skills/reviewing-changes/checklists/dependency-update.md` (+1 -28) 📝 `.claude/skills/reviewing-changes/checklists/feature-addition.md` (+7 -176) 📝 `.claude/skills/reviewing-changes/checklists/infrastructure.md` (+1 -28) 📝 `.claude/skills/reviewing-changes/checklists/refactoring.md` (+1 -28) 📝 `.claude/skills/reviewing-changes/checklists/ui-refinement.md` (+1 -28) 📝 `.claude/skills/reviewing-changes/examples/review-outputs.md` (+19 -6) 📝 `.claude/skills/reviewing-changes/reference/priority-framework.md` (+6 -7) 📝 `.claude/skills/reviewing-changes/reference/review-psychology.md` (+0 -12) </details> ### 📄 Description ## 🎟️ Tracking LLM tooling improvement — no Jira ticket. ## 📔 Objective Adds a `/review-android` slash command and aligns the `reviewing-changes` skill with the `bitwarden-code-reviewer` marketplace agent to eliminate contradictions and redundant content. **New command:** - `.claude/commands/review-android.md` — 3-phase orchestrator (Ingest PR context → Android-specific review → Output findings) following the same pattern as `/plan-android-work` and `/work-on-android` **Skill improvements (`reviewing-changes`):** - Removes redundant `<thinking>` blocks from `SKILL.md` body and duplicate output format sections from all 6 checklist files - Aligns summary format with the agent's `posting-review-summary` skill (adds `<details>` wrapper, surfaces critical issues above fold) - Fixes `QUESTION` emoji (`💭` → `❓`) to match the agent's `classifying-review-findings` skill - Tightens `SUGGESTED` criteria to require measurability (removes vague style/naming suggestions) - Adds priority ordering, Android-specific metadata checks (screenshots for Compose UI changes), and re-review guidance to `SKILL.md` - Removes `Core Directives` from `review-psychology.md` (fully covered by agent standards, no Android-specific value) - Collapses the 140-line inline architecture section in `feature-addition.md` to 4 bullets + reference pointer - Updates `CLAUDE.md` workflow skills list and quick reference --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 16:08:32 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No labels pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32775