github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 11:56:35 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #1988] [MERGED] [EC-312] Fix crash on entering invalid credentials five times on iOS Autofill #3274

New Issue
Closed
opened 2025-11-26 23:30:35 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:35 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1988
Author: @fedemkr
Created: 7/12/2022
Status: ✅ Merged
Merged: 7/14/2022
Merged by: @vvolkgang

Base: master ← Head: bug/ec-312-fix-crash-on-invalid-credentails-5-times

📝 Commits (1)

  • 2bdbf3d EC-312 Fix crash on entering invalid credentials five times on Autofill

📊 Changes

6 files changed (+237 additions, -171 deletions)

View changed files

📝 src/App/Abstractions/IAccountsManager.cs (+1 -0)
📝 src/App/App.xaml.cs (+1 -1)
📝 src/App/Utilities/AccountManagement/AccountsManager.cs (+6 -6)
📝 src/Core/Services/AuthService.cs (+2 -1)
📝 src/iOS.Autofill/CredentialProviderViewController.cs (+211 -138)
📝 src/iOS.Core/Controllers/BaseLockPasswordViewController.cs (+16 -25)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

When the user enters invalid credentials on lock screen on iOS Autofill five times it crashes.

Code changes

  • App.xaml.cs: Added exception handling on navigation call
  • AccountsManager.cs: Made public the logout method and refactor a bit
  • AuthService.cs: Uses the constant for loggedOut now
  • CredentialProviderViewController.cs: Added a bunch of try...catch and fix some async work
  • BaseLockPasswordViewController.cs: Now it calls the proper log out method of the account manager and refactor a bit to reuse code

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1988 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/12/2022 **Status:** ✅ Merged **Merged:** 7/14/2022 **Merged by:** [@vvolkgang](https://github.com/vvolkgang) **Base:** `master` ← **Head:** `bug/ec-312-fix-crash-on-invalid-credentails-5-times` --- ### 📝 Commits (1) - [`2bdbf3d`](https://github.com/bitwarden/android/commit/2bdbf3dbd1fd39d7215f08019e9d796801e4f0c4) EC-312 Fix crash on entering invalid credentials five times on Autofill ### 📊 Changes **6 files changed** (+237 additions, -171 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Abstractions/IAccountsManager.cs` (+1 -0) 📝 `src/App/App.xaml.cs` (+1 -1) 📝 `src/App/Utilities/AccountManagement/AccountsManager.cs` (+6 -6) 📝 `src/Core/Services/AuthService.cs` (+2 -1) 📝 `src/iOS.Autofill/CredentialProviderViewController.cs` (+211 -138) 📝 `src/iOS.Core/Controllers/BaseLockPasswordViewController.cs` (+16 -25) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> When the user enters invalid credentials on lock screen on iOS Autofill five times it crashes. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **App.xaml.cs:** Added exception handling on navigation call * **AccountsManager.cs:** Made public the logout method and refactor a bit * **AuthService.cs:** Uses the constant for loggedOut now * **CredentialProviderViewController.cs:** Added a bunch of try...catch and fix some async work * **BaseLockPasswordViewController.cs:** Now it calls the proper log out method of the account manager and refactor a bit to reuse code ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:35 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?