github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-09 05:20:24 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6605] [MERGED] Update SDK to 2.0.0-5451-c73f9161 #32721

New Issue
Closed
opened 2026-04-18 16:05:14 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 16:05:14 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6605
Author: @bw-ghapp[bot]
Created: 3/2/2026
Status: ✅ Merged
Merged: 3/4/2026
Merged by: @SaintPatrck

Base: main ← Head: sdlc/sdk-update

📝 Commits (5)

  • a652d8e SDK Update - com.bitwarden:sdk-android 2.0.0-5436-42443969
  • bef13de SDK Update - com.bitwarden:sdk-android 2.0.0-5440-5c08ba9c
  • e155886 SDK Update - com.bitwarden:sdk-android 2.0.0-5441-ccc50154
  • 84df98e SDK Update - com.bitwarden:sdk-android 2.0.0-5451-c73f9161
  • e208e6c Fix SDK breaking changes for sdk-android 2.0.0-5451

📊 Changes

12 files changed (+236 additions, -1 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkCipherRepository.kt (+29 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSource.kt (+15 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt (+26 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/CiphersDao.kt (+8 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkCipherRepositoryTest.kt (+77 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryTest.kt (+8 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceTest.kt (+38 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeCiphersDao.kt (+9 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt (+23 -0)
📝 gradle/libs.versions.toml (+1 -1)

📄 Description

Updates the SDK version from 2.0.0-5425-a6f4a233 to com.bitwarden:sdk-android 2.0.0-5451-c73f9161

What's Changed

Raw changelog 
- [PM-32525] Unwrap using key_identifier when generating cipher view key (#801)
- [PM-32510] Add symmetric key envelope (#777)
- [PM-28926] Bulk DB operations (#804)
- [PM-31051] Add V2UpgradeToken for key rotation without logout (#785)

Breaking Changes Resolved

Two SDK commits introduced breaking API changes requiring client-side fixes:

PM-31051: upgradeToken parameter

InitUserCryptoRequest now requires an upgradeToken: V2UpgradeToken? parameter for V2 key rotation support. Since V2 key rotation (PM-22867) is still in design with no client work, all call sites pass null.

PM-28926: Bulk CipherRepository methods

The SDK's CipherRepository interface now requires setBulk, removeBulk, and removeAll methods. These were implemented through the full data layer stack:

  • CiphersDao — Added deleteSelectedCiphers bulk delete query
  • VaultDiskSource/Impl — Added saveCiphers, deleteSelectedCiphers, deleteAllCiphers
  • SdkCipherRepository — Implemented all three overrides with ID validation and empty-input guards

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6605 **Author:** [@bw-ghapp[bot]](https://github.com/apps/bw-ghapp) **Created:** 3/2/2026 **Status:** ✅ Merged **Merged:** 3/4/2026 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `sdlc/sdk-update` --- ### 📝 Commits (5) - [`a652d8e`](https://github.com/bitwarden/android/commit/a652d8ed2227bdf32d10f27aa8155c8a0d6c5882) SDK Update - com.bitwarden:sdk-android 2.0.0-5436-42443969 - [`bef13de`](https://github.com/bitwarden/android/commit/bef13de74a99685fa491621e0192229f607be99a) SDK Update - com.bitwarden:sdk-android 2.0.0-5440-5c08ba9c - [`e155886`](https://github.com/bitwarden/android/commit/e155886c6f4fabac8259a1eec9b5a65794edfb06) SDK Update - com.bitwarden:sdk-android 2.0.0-5441-ccc50154 - [`84df98e`](https://github.com/bitwarden/android/commit/84df98e267c8693c39faefed5e9c5f64caaf3ac7) SDK Update - com.bitwarden:sdk-android 2.0.0-5451-c73f9161 - [`e208e6c`](https://github.com/bitwarden/android/commit/e208e6c1c411b2dbcfab0b3ee0660a42d990c6f1) Fix SDK breaking changes for sdk-android 2.0.0-5451 ### 📊 Changes **12 files changed** (+236 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkCipherRepository.kt` (+29 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryImpl.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSource.kt` (+15 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceImpl.kt` (+26 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/CiphersDao.kt` (+8 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerImpl.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/sdk/repository/SdkCipherRepositoryTest.kt` (+77 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/repository/AuthenticatorBridgeRepositoryTest.kt` (+8 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/VaultDiskSourceTest.kt` (+38 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/datasource/disk/dao/FakeCiphersDao.kt` (+9 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/vault/manager/VaultLockManagerTest.kt` (+23 -0) 📝 `gradle/libs.versions.toml` (+1 -1) </details> ### 📄 Description Updates the SDK version from `2.0.0-5425-a6f4a233` to `com.bitwarden:sdk-android 2.0.0-5451-c73f9161` ## What's Changed - bitwarden/sdk-internal#801 - bitwarden/sdk-internal#777 - bitwarden/sdk-internal#804 - bitwarden/sdk-internal#785 <details> <summary>Raw changelog</summary> ``` - [PM-32525] Unwrap using key_identifier when generating cipher view key (#801) - [PM-32510] Add symmetric key envelope (#777) - [PM-28926] Bulk DB operations (#804) - [PM-31051] Add V2UpgradeToken for key rotation without logout (#785) ``` </details> ## Breaking Changes Resolved Two SDK commits introduced breaking API changes requiring client-side fixes: ### PM-31051: `upgradeToken` parameter `InitUserCryptoRequest` now requires an `upgradeToken: V2UpgradeToken?` parameter for V2 key rotation support. Since V2 key rotation (PM-22867) is still in design with no client work, all call sites pass `null`. ### PM-28926: Bulk `CipherRepository` methods The SDK's `CipherRepository` interface now requires `setBulk`, `removeBulk`, and `removeAll` methods. These were implemented through the full data layer stack: - **`CiphersDao`** — Added `deleteSelectedCiphers` bulk delete query - **`VaultDiskSource`/`Impl`** — Added `saveCiphers`, `deleteSelectedCiphers`, `deleteAllCiphers` - **`SdkCipherRepository`** — Implemented all three overrides with ID validation and empty-input guards [PM-32525]: https://bitwarden.atlassian.net/browse/PM-32525?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-32510]: https://bitwarden.atlassian.net/browse/PM-32510?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-28926]: https://bitwarden.atlassian.net/browse/PM-28926?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [PM-31051]: https://bitwarden.atlassian.net/browse/PM-31051?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 16:05:14 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32721
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?