github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-22 12:32:16 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #1983] [MERGED] [EC-308] Fix crash on avatar image creation on iOS Autofill #3271

New Issue
Closed
opened 2025-11-26 23:30:33 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:33 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1983
Author: @fedemkr
Created: 7/7/2022
Status: ✅ Merged
Merged: 7/7/2022
Merged by: @fedemkr

Base: master ← Head: bug/EC-308-null-ref-acc-sw-avatar-creation

📝 Commits (2)

  • 6c92870 EC-308 Fix crash produced by creating avatar image on AccountSwitchingOverlayHelper and also added more logging to see when it happens.
  • ca27a14 Merge branch 'master' into bug/EC-308-null-ref-acc-sw-avatar-creation

📊 Changes

2 files changed (+28 additions, -8 deletions)

View changed files

📝 src/iOS.Core/Utilities/AccountSwitchingOverlayHelper.cs (+20 -4)
📝 src/iOS.Core/Utilities/ImageSourceExtensions.cs (+8 -4)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fixes crash produced when creating the avatar image on iOS Autofill

Code changes

  • AccountSwitchingOverlayHelper.cs: Added exception handling, default image to return and some logging
  • ImageSourceExtensions.cs: Added proper logging

Screenshots

When an error occurs on creating the avatar image then the default one will be displayed

Default avatar image

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1983 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/7/2022 **Status:** ✅ Merged **Merged:** 7/7/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/EC-308-null-ref-acc-sw-avatar-creation` --- ### 📝 Commits (2) - [`6c92870`](https://github.com/bitwarden/android/commit/6c928708bdefc99c1239f63217c05ba4ba8bc01f) EC-308 Fix crash produced by creating avatar image on AccountSwitchingOverlayHelper and also added more logging to see when it happens. - [`ca27a14`](https://github.com/bitwarden/android/commit/ca27a14f7ae2ab572bde7ae715f334f5c4ae70fd) Merge branch 'master' into bug/EC-308-null-ref-acc-sw-avatar-creation ### 📊 Changes **2 files changed** (+28 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Core/Utilities/AccountSwitchingOverlayHelper.cs` (+20 -4) 📝 `src/iOS.Core/Utilities/ImageSourceExtensions.cs` (+8 -4) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fixes crash produced when creating the avatar image on iOS Autofill ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **AccountSwitchingOverlayHelper.cs:** Added exception handling, default image to return and some logging * **ImageSourceExtensions.cs:** Added proper logging ## Screenshots <!--Required for any UI changes. Delete if not applicable--> When an error occurs on creating the avatar image then the default one will be displayed <img width="314" alt="Default avatar image" src="https://user-images.githubusercontent.com/15682323/177834142-d052c986-b22a-4e9f-a92b-8f6e8d1c4216.PNG"> ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:33 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3271
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?