github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-08 04:16:40 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6514] [MERGED] [PM-32022] Fix browser autofill dialog showing for non-default browsers #32645

New Issue
Closed
opened 2026-04-18 16:00:18 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 16:00:18 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6514
Author: @Vateva
Created: 2/10/2026
Status: ✅ Merged
Merged: 2/17/2026
Merged by: @david-livefront

Base: main ← Head: fix/browser-autofill-dialog-default-browser

📝 Commits (7)

  • 2ce0ddb Fix browser autofill dialog showing for non-default browsers
  • 946b34b Address PR review feedback
  • 8ade5e0 Use singular browser autofill dialog string in all cases
  • 94a87e0 Remove unused plural browser autofill string
  • 8a93ee0 Fix MaxLineLength detekt violation
  • a0f7c1e Wrap multiline when branch in curly braces
  • 7d106f0 Add missing mock stub for defaultBrowserPackageName in AutofillActivityManagerTest

📊 Changes

15 files changed (+93 additions, -7 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt (+2 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserAutofillDialogManagerImpl.kt (+1 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerImpl.kt (+1 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillManager.kt (+5 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillManagerImpl.kt (+13 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/browser/BrowserThirdPartyAutoFillData.kt (+23 -0)
📝 app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt (+1 -5)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt (+2 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserAutofillDialogManagerTest.kt (+39 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerTest.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupBrowserAutofillViewModelTest.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModelTest.kt (+1 -0)
📝 app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/browser/util/BrowserThirdPartyAutofillStatusExtensionsTest.kt (+2 -0)
📝 ui/src/main/res/values/strings.xml (+0 -1)

📄 Description

🎟️ Tracking

https://github.com/bitwarden/android/issues/6471

📔 Objective

The recurring browser autofill pop-up was triggering whenever any supported browser (Chrome, Chrome Beta, Brave, Vivaldi) was installed but not configured for third-party autofill, regardless of whether the user actually used that browser as their default. This caused persistent nagging every 24 hours for users whose default browser is unsupported (e.g., Firefox) or different from the preinstalled Chrome.

Resolved by detecting the device's default browser and only showing the dialog when that specific browser is a supported one with third-party autofill disabled. Onboarding flows continue to check all browsers as before.

📸 Screenshots

N/A — no UI changes, logic-only fix.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6514 **Author:** [@Vateva](https://github.com/Vateva) **Created:** 2/10/2026 **Status:** ✅ Merged **Merged:** 2/17/2026 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `fix/browser-autofill-dialog-default-browser` --- ### 📝 Commits (7) - [`2ce0ddb`](https://github.com/bitwarden/android/commit/2ce0ddbde14b1723921f3f791f03850ae5eebdaf) Fix browser autofill dialog showing for non-default browsers - [`946b34b`](https://github.com/bitwarden/android/commit/946b34bde2147c561f44ebf32901e67af90f7d8a) Address PR review feedback - [`8ade5e0`](https://github.com/bitwarden/android/commit/8ade5e080c1e164b843e6d7c43b4c82fc2b7f86c) Use singular browser autofill dialog string in all cases - [`94a87e0`](https://github.com/bitwarden/android/commit/94a87e0a82160e36b209eec2638232a09deb553f) Remove unused plural browser autofill string - [`8a93ee0`](https://github.com/bitwarden/android/commit/8a93ee0187cb94f914a40e700842dfa08385620f) Fix MaxLineLength detekt violation - [`a0f7c1e`](https://github.com/bitwarden/android/commit/a0f7c1e482216606a3abf6dcbf948d92954ee70f) Wrap multiline when branch in curly braces - [`7d106f0`](https://github.com/bitwarden/android/commit/7d106f0a8e2cd8f6cd663bc37078783cef3957f7) Add missing mock stub for defaultBrowserPackageName in AutofillActivityManagerTest ### 📊 Changes **15 files changed** (+93 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerImpl.kt` (+2 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserAutofillDialogManagerImpl.kt` (+1 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerImpl.kt` (+1 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillManager.kt` (+5 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillManagerImpl.kt` (+13 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/autofill/model/browser/BrowserThirdPartyAutoFillData.kt` (+23 -0) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/ui/vault/feature/vault/VaultScreen.kt` (+1 -5) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/AutofillActivityManagerTest.kt` (+2 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserAutofillDialogManagerTest.kt` (+39 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/autofill/manager/browser/BrowserThirdPartyAutofillEnabledManagerTest.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/data/platform/manager/FirstTimeActionManagerTest.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/auth/feature/accountsetup/SetupBrowserAutofillViewModelTest.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/AutoFillViewModelTest.kt` (+1 -0) 📝 `app/src/test/kotlin/com/x8bit/bitwarden/ui/platform/feature/settings/autofill/browser/util/BrowserThirdPartyAutofillStatusExtensionsTest.kt` (+2 -0) 📝 `ui/src/main/res/values/strings.xml` (+0 -1) </details> ### 📄 Description ## 🎟️ Tracking https://github.com/bitwarden/android/issues/6471 ## 📔 Objective The recurring browser autofill pop-up was triggering whenever **any** supported browser (Chrome, Chrome Beta, Brave, Vivaldi) was installed but not configured for third-party autofill, regardless of whether the user actually used that browser as their default. This caused persistent nagging every 24 hours for users whose default browser is unsupported (e.g., Firefox) or different from the preinstalled Chrome. Resolved by detecting the device's default browser and only showing the dialog when **that specific browser** is a supported one with third-party autofill disabled. Onboarding flows continue to check all browsers as before. ## 📸 Screenshots N/A — no UI changes, logic-only fix. ## ⏰ Reminders before review - [x] Contributor guidelines followed - [x] All formatters and local linters executed and passed - [x] Written new unit and / or integration tests where applicable - [ ] Protected functional changes with optionality (feature flags) - [ ] Used internationalization (i18n) for all UI strings - [ ] CI builds passed - [ ] Communicated to DevOps any deployment requirements - [ ] Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 16:00:18 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32645
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?