github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-10 12:13:43 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1974] [MERGED] [EC-297] Fix possible crash when copying password on cipher item view #3263

New Issue
Closed
opened 2025-11-26 23:30:27 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:27 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1974
Author: @fedemkr
Created: 7/4/2022
Status: ✅ Merged
Merged: 7/5/2022
Merged by: @fedemkr

Base: master ← Head: EC-297-try-catch-on-copy-password

📝 Commits (1)

  • 68d4ec6 EC-297 Fix possible crash when copying password on cipher item view. Also improved a bit the code of copying commands

📊 Changes

2 files changed (+26 additions, -24 deletions)

View changed files

📝 src/Android/Services/ClipboardService.cs (+15 -7)
📝 src/App/Pages/Vault/ViewPageViewModel.cs (+11 -17)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix possible crash when copying password on cipher item view

Code changes

  • ClipboardService.cs: Added try catch ignore for the specific exception on the issue reported
  • ViewPageViewModel.cs: Improved the copying commands

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1974 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 7/4/2022 **Status:** ✅ Merged **Merged:** 7/5/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `EC-297-try-catch-on-copy-password` --- ### 📝 Commits (1) - [`68d4ec6`](https://github.com/bitwarden/android/commit/68d4ec6fa2f8028cf14ba8d7003b5b312bc70377) EC-297 Fix possible crash when copying password on cipher item view. Also improved a bit the code of copying commands ### 📊 Changes **2 files changed** (+26 additions, -24 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Services/ClipboardService.cs` (+15 -7) 📝 `src/App/Pages/Vault/ViewPageViewModel.cs` (+11 -17) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix possible crash when copying password on cipher item view ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ClipboardService.cs:** Added try catch ignore for the specific exception on the issue reported * **ViewPageViewModel.cs:** Improved the copying commands ## Before you submit - [X] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:27 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?