github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1965] [MERGED] Add ssoToken to limit lifetime of SSO redirect #3257

New Issue
Closed
opened 2025-11-26 23:30:22 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:22 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1965
Author: @MGibson1
Created: 6/27/2022
Status: ✅ Merged
Merged: 6/27/2022
Merged by: @MGibson1

Base: master ← Head: ps-1008-add-sso-validity-token-to-sso-auth

📝 Commits (1)

  • 4f0c3a3 Add ssoToken to limit lifetime of SSO redirect

📊 Changes

4 files changed (+16 additions, -5 deletions)

View changed files

📝 src/App/Pages/Accounts/LoginSsoPageViewModel.cs (+5 -2)
📝 src/Core/Abstractions/IApiService.cs (+1 -1)
➕ src/Core/Models/Response/SsoPrevalidateResponse.cs (+7 -0)
📝 src/Core/Services/ApiService.cs (+3 -2)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Mobile implementation of bitwarden/jslib#780. Adds an expiring token to SSO page redirects.

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1965 **Author:** [@MGibson1](https://github.com/MGibson1) **Created:** 6/27/2022 **Status:** ✅ Merged **Merged:** 6/27/2022 **Merged by:** [@MGibson1](https://github.com/MGibson1) **Base:** `master` ← **Head:** `ps-1008-add-sso-validity-token-to-sso-auth` --- ### 📝 Commits (1) - [`4f0c3a3`](https://github.com/bitwarden/android/commit/4f0c3a3fa6813f5908247fca35baae978ed48bbc) Add ssoToken to limit lifetime of SSO redirect ### 📊 Changes **4 files changed** (+16 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/LoginSsoPageViewModel.cs` (+5 -2) 📝 `src/Core/Abstractions/IApiService.cs` (+1 -1) ➕ `src/Core/Models/Response/SsoPrevalidateResponse.cs` (+7 -0) 📝 `src/Core/Services/ApiService.cs` (+3 -2) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Mobile implementation of bitwarden/jslib#780. Adds an expiring token to SSO page redirects. ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:22 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?