github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 11:56:35 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #1961] [MERGED] [PS-686] Mobile update negative copy in settings #3255

New Issue
Closed
opened 2025-11-26 23:30:20 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:20 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1961
Author: @coroiu
Created: 6/21/2022
Status: ✅ Merged
Merged: 7/11/2022
Merged by: @coroiu

Base: master ← Head: PS-686-mobile-update-negative-copy-in-settings

📝 Commits (7)

  • 0764f4b feat: update auto totp copy setting
  • 6c115ae feat: update show icons settings
  • e8201ba feat: update auto add settings
  • 0f3937c feat: update settings and options to sentence case
  • 1104250 feat: update translation keys
  • c1ef982 fix: revert AndroidManifest changes
  • 5bc95f9 chore: add todo comments to fix negative functions

📊 Changes

7 files changed (+79 additions, -86 deletions)

View changed files

📝 src/App/Pages/Settings/OptionsPage.xaml (+9 -9)
📝 src/App/Pages/Settings/OptionsPageViewModel.cs (+25 -24)
📝 src/App/Resources/AppResources.Designer.cs (+15 -13)
📝 src/App/Resources/AppResources.resx (+29 -29)
📝 src/Core/Abstractions/ITotpService.cs (+0 -1)
📝 src/Core/Services/TotpService.cs (+0 -9)
📝 src/Core/Utilities/ServiceContainer.cs (+1 -1)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Update Negative Copy in Settings

All clients do not use a consistent method for labeling settings controls. We often see settings that include the word "Disable" along with a checkmark which implies "enabling" a disable; this can be confusing for users.

Code changes

  • file.ext: Description of what was changed and why

Screenshots

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1961 **Author:** [@coroiu](https://github.com/coroiu) **Created:** 6/21/2022 **Status:** ✅ Merged **Merged:** 7/11/2022 **Merged by:** [@coroiu](https://github.com/coroiu) **Base:** `master` ← **Head:** `PS-686-mobile-update-negative-copy-in-settings` --- ### 📝 Commits (7) - [`0764f4b`](https://github.com/bitwarden/android/commit/0764f4bfa70662cd7e5f525740966651ac95b501) feat: update auto totp copy setting - [`6c115ae`](https://github.com/bitwarden/android/commit/6c115ae5d36d753077404c3f8b3c6b441e534da0) feat: update show icons settings - [`e8201ba`](https://github.com/bitwarden/android/commit/e8201ba0fea89957d481f20284495a64e612e6c3) feat: update auto add settings - [`0f3937c`](https://github.com/bitwarden/android/commit/0f3937c8e9d4a146c4a577fe80a45f6f6b8bd15c) feat: update settings and options to sentence case - [`1104250`](https://github.com/bitwarden/android/commit/11042505eb664b50e86cf8fd34c593abac6aae5d) feat: update translation keys - [`c1ef982`](https://github.com/bitwarden/android/commit/c1ef9823fbbb0e6744b086efcdd39cd85f5b7a98) fix: revert AndroidManifest changes - [`5bc95f9`](https://github.com/bitwarden/android/commit/5bc95f9f24910dc8c979a5d712b760e4e67d7f93) chore: add todo comments to fix negative functions ### 📊 Changes **7 files changed** (+79 additions, -86 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Settings/OptionsPage.xaml` (+9 -9) 📝 `src/App/Pages/Settings/OptionsPageViewModel.cs` (+25 -24) 📝 `src/App/Resources/AppResources.Designer.cs` (+15 -13) 📝 `src/App/Resources/AppResources.resx` (+29 -29) 📝 `src/Core/Abstractions/ITotpService.cs` (+0 -1) 📝 `src/Core/Services/TotpService.cs` (+0 -9) 📝 `src/Core/Utilities/ServiceContainer.cs` (+1 -1) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [x] Other ## Objective Update Negative Copy in Settings All clients do not use a consistent method for labeling settings controls. We often see settings that include the word "Disable" along with a checkmark which implies "enabling" a disable; this can be [confusing for users](https://www.reddit.com/r/Bitwarden/comments/qhns9l/browser_extensions_can_now_autoprompt_for/). ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **file.ext:** Description of what was changed and why ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:20 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?