github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6229] [MERGED] [PM-28352] Add logging to Credential Manager and Origin Manager flows #32427

New Issue
Closed
opened 2026-04-18 15:48:54 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 15:48:54 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6229
Author: @SaintPatrck
Created: 12/4/2025
Status: ✅ Merged
Merged: 12/4/2025
Merged by: @SaintPatrck

Base: main ← Head: log-credential-manager-flows

📝 Commits (2)

  • 70cc148 Add logging to Credential Manager and Origin Manager flows
  • fc8ca76 Remove package name logging from OriginManagerImpl and minor log cleanup

📊 Changes

2 files changed (+24 additions, -4 deletions)

View changed files

📝 app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/OriginManagerImpl.kt (+3 -1)
📝 app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/processor/CredentialProviderProcessorImpl.kt (+21 -3)

📄 Description

🎟️ Tracking

PM-28352

📔 Objective

Enhance the observability of the Credential Provider implementation by adding Timber logs to key lifecycle events and error handling paths. This facilitates better debugging of credential creation, retrieval, and origin validation processes.

Specific changes include:

  • Update OriginManagerImpl to log the success status of digital asset link validation and error details if validation fails.
  • Update CredentialProviderProcessorImpl to log entry points for onBeginCreateCredentialRequest, onBeginGetCredentialRequest, and onClearCredentialStateRequest.
  • Add specific logs for edge cases such as missing active users, locked vaults, and unknown request types.
  • Log success and failure outcomes for credential operations, as well as system-triggered cancellations.
  • Minor refactor in onBeginCreateCredentialRequest to accommodate the new logging logic within the failure branch.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6229 **Author:** [@SaintPatrck](https://github.com/SaintPatrck) **Created:** 12/4/2025 **Status:** ✅ Merged **Merged:** 12/4/2025 **Merged by:** [@SaintPatrck](https://github.com/SaintPatrck) **Base:** `main` ← **Head:** `log-credential-manager-flows` --- ### 📝 Commits (2) - [`70cc148`](https://github.com/bitwarden/android/commit/70cc148b9228281394223520868b5c1caa8c4c08) Add logging to Credential Manager and Origin Manager flows - [`fc8ca76`](https://github.com/bitwarden/android/commit/fc8ca76b037027d74d29f93cdfcf95cefc8d7db9) Remove package name logging from OriginManagerImpl and minor log cleanup ### 📊 Changes **2 files changed** (+24 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/manager/OriginManagerImpl.kt` (+3 -1) 📝 `app/src/main/kotlin/com/x8bit/bitwarden/data/credentials/processor/CredentialProviderProcessorImpl.kt` (+21 -3) </details> ### 📄 Description ## 🎟️ Tracking PM-28352 ## 📔 Objective Enhance the observability of the Credential Provider implementation by adding `Timber` logs to key lifecycle events and error handling paths. This facilitates better debugging of credential creation, retrieval, and origin validation processes. Specific changes include: - Update `OriginManagerImpl` to log the success status of digital asset link validation and error details if validation fails. - Update `CredentialProviderProcessorImpl` to log entry points for `onBeginCreateCredentialRequest`, `onBeginGetCredentialRequest`, and `onClearCredentialStateRequest`. - Add specific logs for edge cases such as missing active users, locked vaults, and unknown request types. - Log success and failure outcomes for credential operations, as well as system-triggered cancellations. - Minor refactor in `onBeginCreateCredentialRequest` to accommodate the new logging logic within the failure branch. ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 15:48:54 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32427
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?