github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-22 20:41:29 -05:00
Code Issues 144 Packages Projects Releases 118 Wiki Activity

[PR #1941] [MERGED] PS-587 - Fix searchbar search textfield and icon colors for dark themes #3238

New Issue
Closed
opened 2025-11-26 23:30:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1941
Author: @LRNcardozoWDF
Created: 6/6/2022
Status: ✅ Merged
Merged: 6/7/2022
Merged by: @LRNcardozoWDF

Base: master ← Head: bug/PS-587-fix-autofill-searchbar-darktheme

📝 Commits (2)

  • 5c41775 PS-587 Fix searchbar search textfield and icon colors for dark themes
  • 37ed5bf PS-587 - PR corrections

📊 Changes

3 files changed (+22 additions, -4 deletions)

View changed files

📝 src/iOS.Autofill/LoginSearchViewController.cs (+1 -4)
➕ src/iOS.Core/Utilities/UISearchBarExtensions.cs (+20 -0)
📝 src/iOS.Core/iOS.Core.csproj (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

With these changes, autofill iOS extension searchbar's search text and icon should appear as white for non light themes.

Code changes

  • LoginSearchViewController.cs: Invoked new method extension ApplyDarkThemesColors from UISearchBarExtensions.cs
  • UISearchBarExtensions.cs: Applied white color to search text and icon only for iOS versions greater or equal than 13 because this solution isn't supported for prior versions.

Screenshots

Without the fix:
image

With the fix:
Dark theme

image

Black theme
image

Nord theme
image

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1941 **Author:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Created:** 6/6/2022 **Status:** ✅ Merged **Merged:** 6/7/2022 **Merged by:** [@LRNcardozoWDF](https://github.com/LRNcardozoWDF) **Base:** `master` ← **Head:** `bug/PS-587-fix-autofill-searchbar-darktheme` --- ### 📝 Commits (2) - [`5c41775`](https://github.com/bitwarden/android/commit/5c41775f2337fbe2db2fce4b632408e9f304d223) PS-587 Fix searchbar search textfield and icon colors for dark themes - [`37ed5bf`](https://github.com/bitwarden/android/commit/37ed5bf0fa00e15aa39a98cffaefbec5b9b6830a) PS-587 - PR corrections ### 📊 Changes **3 files changed** (+22 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/iOS.Autofill/LoginSearchViewController.cs` (+1 -4) ➕ `src/iOS.Core/Utilities/UISearchBarExtensions.cs` (+20 -0) 📝 `src/iOS.Core/iOS.Core.csproj` (+1 -0) </details> ### 📄 Description ## Type of change - [x] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective With these changes, autofill iOS extension searchbar's search text and icon should appear as white for non light themes. ## Code changes * **LoginSearchViewController.cs**: Invoked new method extension ApplyDarkThemesColors from UISearchBarExtensions.cs * **UISearchBarExtensions.cs**: Applied white color to search text and icon only for iOS versions greater or equal than 13 because this solution isn't supported for prior versions. ## Screenshots Without the fix: <img width="419" alt="image" src="https://user-images.githubusercontent.com/6855596/172208150-09511f30-922c-4b72-9060-d8e1e04d4f70.png"> With the fix: Dark theme <img width="419" alt="image" src="https://user-images.githubusercontent.com/6855596/172208885-fd77d215-4261-4939-bc20-2018c3379bbf.png"> Black theme <img width="419" alt="image" src="https://user-images.githubusercontent.com/6855596/172209061-f41ddb4d-51a6-4c34-a809-9faa44ad58ff.png"> Nord theme <img width="419" alt="image" src="https://user-images.githubusercontent.com/6855596/172209178-6c276c61-42e4-4acf-8bee-3915719ca104.png"> ## Before you submit - [x] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3238
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?