github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-15 06:59:05 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1940] [MERGED] Adaptive icon theme support in Android 13 #3237

New Issue
Closed
opened 2025-11-26 23:30:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:30:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1940
Author: @mpbw2
Created: 6/6/2022
Status: ✅ Merged
Merged: 6/6/2022
Merged by: @mpbw2

Base: master ← Head: feature-themedicon

📝 Commits (1)

  • 101a825 Added monochrome element to adaptive icon for theme support in Android 13

📊 Changes

2 files changed (+2 additions, -0 deletions)

View changed files

📝 src/Android/Resources/mipmap-anydpi-v26/ic_launcher.xml (+1 -0)
📝 src/Android/Resources/mipmap-anydpi-v26/ic_launcher_round.xml (+1 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Adds support for launcher icon themes in Android 13. (Turns out this doesn't require SDK/target updates that were holding us back in Xamarin) Reference: https://developer.android.com/about/versions/13/features

Code changes

  • ic_launcher/round.xml: Added monochrome element to logo vectordrawable for theme support in Android 13

Screenshots

Screen Shot 2022-06-06 at 10 13 27 AM

Before you submit

  • I have checked for formatting errors (dotnet tool run dotnet-format --check) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1940 **Author:** [@mpbw2](https://github.com/mpbw2) **Created:** 6/6/2022 **Status:** ✅ Merged **Merged:** 6/6/2022 **Merged by:** [@mpbw2](https://github.com/mpbw2) **Base:** `master` ← **Head:** `feature-themedicon` --- ### 📝 Commits (1) - [`101a825`](https://github.com/bitwarden/android/commit/101a825c4f77de75b68b0ac53f508cf07adff741) Added monochrome element to adaptive icon for theme support in Android 13 ### 📊 Changes **2 files changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Resources/mipmap-anydpi-v26/ic_launcher.xml` (+1 -0) 📝 `src/Android/Resources/mipmap-anydpi-v26/ic_launcher_round.xml` (+1 -0) </details> ### 📄 Description ## Type of change - [ ] Bug fix - [X] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Adds support for launcher icon themes in Android 13. (Turns out this doesn't require SDK/target updates that were holding us back in Xamarin) Reference: https://developer.android.com/about/versions/13/features ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **ic_launcher/round.xml:** Added monochrome element to logo vectordrawable for theme support in Android 13 ## Screenshots <!--Required for any UI changes. Delete if not applicable--> ![Screen Shot 2022-06-06 at 10 13 27 AM](https://user-images.githubusercontent.com/59324545/172181378-65af4f96-3bbf-4c79-a858-e35e095f7d82.png) ## Before you submit - [ ] I have checked for formatting errors (`dotnet tool run dotnet-format --check`) (required) - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:30:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3237
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?