github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-09 11:44:41 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1930] [MERGED] [PS-536] Fix vault blank after unlocking and back navigation #3228

New Issue
Closed
opened 2025-11-26 23:29:59 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:59 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1930
Author: @fedemkr
Created: 5/27/2022
Status: ✅ Merged
Merged: 5/27/2022
Merged by: @fedemkr

Base: master ← Head: bug/PS-536-fix-vault-blank-after-unlocking-ios

📝 Commits (2)

  • ed068f9 PS-536 Fix by hack vault blank after unlocking and back navigate when previous page has value on iOS
  • baa58ef PS-536 Added platform check to the hack so it doesn't affect Android performance given that's an issue particular for iOS

📊 Changes

1 file changed (+12 additions, -0 deletions)

View changed files

📝 src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs (+12 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix vault blank after unlocking and closing the modal when the user had locked the vault when viewing a cipher. It may fix #1274 as well.

Code changes

  • GroupingsPageViewModel.cs: Added Clear call to the GroupedItems collection before replacing in order to invalidate the internal UICollectionView layout and the Replace to work as expected. This issue was introduce by the update to XF v5.0.0.2401. This workarounds the issue but we should keep checking this for a better solution or hope the next version fixes it.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1930 **Author:** [@fedemkr](https://github.com/fedemkr) **Created:** 5/27/2022 **Status:** ✅ Merged **Merged:** 5/27/2022 **Merged by:** [@fedemkr](https://github.com/fedemkr) **Base:** `master` ← **Head:** `bug/PS-536-fix-vault-blank-after-unlocking-ios` --- ### 📝 Commits (2) - [`ed068f9`](https://github.com/bitwarden/android/commit/ed068f936a19e684247ac988c0a7c04e4fdaa005) PS-536 Fix by hack vault blank after unlocking and back navigate when previous page has value on iOS - [`baa58ef`](https://github.com/bitwarden/android/commit/baa58ef30e51d013e25c6161c2937d848ef25406) PS-536 Added platform check to the hack so it doesn't affect Android performance given that's an issue particular for iOS ### 📊 Changes **1 file changed** (+12 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Vault/GroupingsPage/GroupingsPageViewModel.cs` (+12 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective <!--Describe what the purpose of this PR is. For example: what bug you're fixing or what new feature you're adding--> Fix vault blank after unlocking and closing the modal when the user had locked the vault when viewing a cipher. It may fix #1274 as well. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **GroupingsPageViewModel.cs:** Added `Clear` call to the `GroupedItems` collection before replacing in order to invalidate the internal `UICollectionView` layout and the Replace to work as expected. This issue was introduce by the update to XF v5.0.0.2401. This workarounds the issue but we should keep checking this for a better solution or hope the next version fixes it. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:59 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3228
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?