github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 03:21:29 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #1929] [MERGED] PS-689 Android: Accessibility - back buttons in search and vault > bin lack appropriate accessible name #3227

New Issue
Closed
opened 2025-11-26 23:29:58 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:58 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1929
Author: @andrebispo5
Created: 5/27/2022
Status: ✅ Merged
Merged: 6/1/2022
Merged by: @andrebispo5

Base: master ← Head: bug/ps-689-back-voiceover

📝 Commits (4)

  • 9c5ea8c PS-689 Added back buttons accessibility text
  • 6190a8a PS-689 Changed resource key from "GoBack" to "TapToGoBack"
  • 6f2073d Merge branch 'master' into bug/ps-689-back-voiceover
  • bf3a8db PS-689: class rename

📊 Changes

5 files changed (+44 additions, -1 deletions)

View changed files

📝 src/Android/Android.csproj (+1 -0)
➕ src/Android/Renderers/CustomPageRenderer.cs (+31 -0)
📝 src/App/Pages/Vault/CiphersPage.xaml (+3 -1)
📝 src/App/Resources/AppResources.Designer.cs (+6 -0)
📝 src/App/Resources/AppResources.resx (+3 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Android back buttons throughout the app don't have accessibility text. Add text to be read by the VoiceOver\TalkBack on the back button.

Code changes

  • src/Android/Renderers/CustomPageRenderer.cs: Toolbar back button was only accessible through a custom renderer.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1929 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/27/2022 **Status:** ✅ Merged **Merged:** 6/1/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bug/ps-689-back-voiceover` --- ### 📝 Commits (4) - [`9c5ea8c`](https://github.com/bitwarden/android/commit/9c5ea8cfc0df9f5cd92be51323584e7f9e28b2e2) PS-689 Added back buttons accessibility text - [`6190a8a`](https://github.com/bitwarden/android/commit/6190a8a9746fc2a80a9d5666021ad4d34c814798) PS-689 Changed resource key from "GoBack" to "TapToGoBack" - [`6f2073d`](https://github.com/bitwarden/android/commit/6f2073db251d01e33a762b03006352d8102bd72c) Merge branch 'master' into bug/ps-689-back-voiceover - [`bf3a8db`](https://github.com/bitwarden/android/commit/bf3a8db0ea36888bf0d0bcfd662f5a689c8be667) PS-689: class rename ### 📊 Changes **5 files changed** (+44 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/Android/Android.csproj` (+1 -0) ➕ `src/Android/Renderers/CustomPageRenderer.cs` (+31 -0) 📝 `src/App/Pages/Vault/CiphersPage.xaml` (+3 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+6 -0) 📝 `src/App/Resources/AppResources.resx` (+3 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Android back buttons throughout the app don't have accessibility text. Add text to be read by the VoiceOver\TalkBack on the back button. ## Code changes * **src/Android/Renderers/CustomPageRenderer.cs:** Toolbar back button was only accessible through a custom renderer. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:58 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3227
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?