github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-06 07:48:22 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #6033] [MERGED] [PM-26909] Implement screen capture toggle authenticator #32263

New Issue
Closed
opened 2026-04-18 15:39:40 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 15:39:40 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/6033
Author: @aj-rosado
Created: 10/15/2025
Status: ✅ Merged
Merged: 10/16/2025
Merged by: @aj-rosado

Base: main ← Head: PM-26909/implement-screen-capture-toggle-authenticator

📝 Commits (4)

  • 2be25e8 Add screen capture toggle to settings
  • 67a6322 added tests to screen capture toggle
  • 4a70adb fixed card styling and improved formatting
  • c73d8d2 ScreenCaptureRow now receives CardStyle

📊 Changes

5 files changed (+162 additions, -13 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepository.kt (+4 -4)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt (+74 -8)
📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsViewModel.kt (+21 -1)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreenTest.kt (+34 -0)
📝 authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsViewModelTest.kt (+29 -0)

📄 Description

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-26909

📔 Objective

Add screen capture toggle for Authenticator

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

📸 Screenshots

Screenshot_1760611798 Screenshot_1760611853 Screenshot_1760611858

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/6033 **Author:** [@aj-rosado](https://github.com/aj-rosado) **Created:** 10/15/2025 **Status:** ✅ Merged **Merged:** 10/16/2025 **Merged by:** [@aj-rosado](https://github.com/aj-rosado) **Base:** `main` ← **Head:** `PM-26909/implement-screen-capture-toggle-authenticator` --- ### 📝 Commits (4) - [`2be25e8`](https://github.com/bitwarden/android/commit/2be25e83e8dcddd36ce4011d3437587925bb1e86) Add screen capture toggle to settings - [`67a6322`](https://github.com/bitwarden/android/commit/67a632230c4b0fd2d46c694da35a166a29168304) added tests to screen capture toggle - [`4a70adb`](https://github.com/bitwarden/android/commit/4a70adb7712ecbdadbf6a57518b14a85a5ad4eaf) fixed card styling and improved formatting - [`c73d8d2`](https://github.com/bitwarden/android/commit/c73d8d2d2dd4639a7c39971e09cfb761aa758ccd) ScreenCaptureRow now receives CardStyle ### 📊 Changes **5 files changed** (+162 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/data/platform/repository/SettingsRepository.kt` (+4 -4) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreen.kt` (+74 -8) 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsViewModel.kt` (+21 -1) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsScreenTest.kt` (+34 -0) 📝 `authenticator/src/test/kotlin/com/bitwarden/authenticator/ui/platform/feature/settings/SettingsViewModelTest.kt` (+29 -0) </details> ### 📄 Description ## 🎟️ Tracking https://bitwarden.atlassian.net/browse/PM-26909 ## 📔 Objective Add screen capture toggle for Authenticator ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 📸 Screenshots <img width="316" alt="Screenshot_1760611798" src="https://github.com/user-attachments/assets/496987c0-da38-48a7-9f87-fc4440209ed3" /> <img width="316" alt="Screenshot_1760611853" src="https://github.com/user-attachments/assets/a19ea552-1051-4cd1-9fc6-45fcaa85d791" /> <img width="316" alt="Screenshot_1760611858" src="https://github.com/user-attachments/assets/341cb15e-8176-4fe8-a5e8-ed3c0738789b" /> ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 15:39:40 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32263
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?