github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-21 03:21:29 -05:00
Code Issues 1.5k Packages Projects Releases 125 Wiki Activity

[PR #1926] [MERGED] PS-675 Added accessibility text to password show/hide toggles #3224

New Issue
Closed
opened 2025-11-26 23:29:56 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:56 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1926
Author: @andrebispo5
Created: 5/26/2022
Status: ✅ Merged
Merged: 6/1/2022
Merged by: @andrebispo5

Base: master ← Head: bug/ps-675-showhide-pass-voiceover

📝 Commits (3)

  • 0579176 PS-675 Added accessibility text to password show hide toggles
  • f2291ce PS-675 refactor string resource key name
  • 8edce17 Merge branch 'master' into bug/ps-675-showhide-pass-voiceover

📊 Changes

20 files changed (+77 additions, -19 deletions)

View changed files

📝 src/App/Pages/Accounts/BaseChangePasswordViewModel.cs (+6 -1)
📝 src/App/Pages/Accounts/LockPage.xaml (+4 -2)
📝 src/App/Pages/Accounts/LockPageViewModel.cs (+3 -1)
📝 src/App/Pages/Accounts/LoginPage.xaml (+2 -1)
📝 src/App/Pages/Accounts/LoginPageViewModel.cs (+3 -1)
📝 src/App/Pages/Accounts/RegisterPage.xaml (+4 -2)
📝 src/App/Pages/Accounts/RegisterPageViewModel.cs (+3 -1)
📝 src/App/Pages/Accounts/SetPasswordPage.xaml (+4 -2)
📝 src/App/Pages/Accounts/SetPasswordPageViewModel.cs (+6 -1)
📝 src/App/Pages/Accounts/UpdateTempPasswordPage.xaml (+4 -2)
📝 src/App/Pages/Send/SendAddEditPage.xaml (+2 -1)
📝 src/App/Pages/Send/SendAddEditPageViewModel.cs (+3 -1)
📝 src/App/Pages/Settings/ExportVaultPage.xaml (+1 -0)
📝 src/App/Pages/Settings/ExportVaultPageViewModel.cs (+6 -1)
📝 src/App/Pages/Vault/AddEditPage.xaml (+1 -0)
📝 src/App/Pages/Vault/AddEditPageViewModel.cs (+3 -1)
📝 src/App/Pages/Vault/ViewPage.xaml (+1 -0)
📝 src/App/Pages/Vault/ViewPageViewModel.cs (+3 -1)
📝 src/App/Resources/AppResources.Designer.cs (+12 -0)
📝 src/App/Resources/AppResources.resx (+6 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Password show/hide toggles show indicate the state to the user.

Code changes

Added text resource to represent the visibility of the password. Used this resource on all password toggles.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1926 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/26/2022 **Status:** ✅ Merged **Merged:** 6/1/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bug/ps-675-showhide-pass-voiceover` --- ### 📝 Commits (3) - [`0579176`](https://github.com/bitwarden/android/commit/057917601101b6a0095e6a6bcc22e0a269930164) PS-675 Added accessibility text to password show hide toggles - [`f2291ce`](https://github.com/bitwarden/android/commit/f2291cedd43d8b55bd4cc21b3ada6899f9065921) PS-675 refactor string resource key name - [`8edce17`](https://github.com/bitwarden/android/commit/8edce17dd529da0ae7de7cb45a24a72e7f7085ea) Merge branch 'master' into bug/ps-675-showhide-pass-voiceover ### 📊 Changes **20 files changed** (+77 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Accounts/BaseChangePasswordViewModel.cs` (+6 -1) 📝 `src/App/Pages/Accounts/LockPage.xaml` (+4 -2) 📝 `src/App/Pages/Accounts/LockPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Accounts/LoginPage.xaml` (+2 -1) 📝 `src/App/Pages/Accounts/LoginPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Accounts/RegisterPage.xaml` (+4 -2) 📝 `src/App/Pages/Accounts/RegisterPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Accounts/SetPasswordPage.xaml` (+4 -2) 📝 `src/App/Pages/Accounts/SetPasswordPageViewModel.cs` (+6 -1) 📝 `src/App/Pages/Accounts/UpdateTempPasswordPage.xaml` (+4 -2) 📝 `src/App/Pages/Send/SendAddEditPage.xaml` (+2 -1) 📝 `src/App/Pages/Send/SendAddEditPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Settings/ExportVaultPage.xaml` (+1 -0) 📝 `src/App/Pages/Settings/ExportVaultPageViewModel.cs` (+6 -1) 📝 `src/App/Pages/Vault/AddEditPage.xaml` (+1 -0) 📝 `src/App/Pages/Vault/AddEditPageViewModel.cs` (+3 -1) 📝 `src/App/Pages/Vault/ViewPage.xaml` (+1 -0) 📝 `src/App/Pages/Vault/ViewPageViewModel.cs` (+3 -1) 📝 `src/App/Resources/AppResources.Designer.cs` (+12 -0) 📝 `src/App/Resources/AppResources.resx` (+6 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Password show/hide toggles show indicate the state to the user. ## Code changes Added text resource to represent the visibility of the password. Used this resource on all password toggles. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:56 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3224
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?