github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-05-07 19:39:41 -05:00
Code Issues 1.1k Packages Projects Releases 122 Wiki Activity

[PR #5989] [MERGED] Simplify the BitwardenExpandableFloatingActionButton #32223

New Issue
Closed
opened 2026-04-18 15:37:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-18 15:37:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/5989
Author: @david-livefront
Created: 10/8/2025
Status: ✅ Merged
Merged: 10/8/2025
Merged by: @david-livefront

Base: main ← Head: simplify-extendable-fab

📝 Commits (1)

  • fc9e9f4 Simplify the BitwardenExpandableFloatingActionButton

📊 Changes

5 files changed (+77 additions, -128 deletions)

View changed files

📝 authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt (+6 -6)
➖ authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/model/ItemListingExpandableFabAction.kt (+0 -42)
📝 ui/src/main/kotlin/com/bitwarden/ui/platform/components/fab/BitwardenExpandableFloatingActionButton.kt (+47 -80)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/components/fab/model/ExpandableFabIcon.kt (+11 -0)
➕ ui/src/main/kotlin/com/bitwarden/ui/platform/components/fab/model/ExpandableFabOption.kt (+13 -0)

📄 Description

🎟️ Tracking

N/A

📔 Objective

This PR simplifies the BitwardenExpandableFloatingActionButton.

  • Removed the need for custom classes and generics
  • Simplified the expanded state
  • Fixed state restoration after config change (this is what started it all 😄 )

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/5989 **Author:** [@david-livefront](https://github.com/david-livefront) **Created:** 10/8/2025 **Status:** ✅ Merged **Merged:** 10/8/2025 **Merged by:** [@david-livefront](https://github.com/david-livefront) **Base:** `main` ← **Head:** `simplify-extendable-fab` --- ### 📝 Commits (1) - [`fc9e9f4`](https://github.com/bitwarden/android/commit/fc9e9f422824fd19c931cf29b967866f1fe871f1) Simplify the BitwardenExpandableFloatingActionButton ### 📊 Changes **5 files changed** (+77 additions, -128 deletions) <details> <summary>View changed files</summary> 📝 `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/ItemListingScreen.kt` (+6 -6) ➖ `authenticator/src/main/kotlin/com/bitwarden/authenticator/ui/authenticator/feature/itemlisting/model/ItemListingExpandableFabAction.kt` (+0 -42) 📝 `ui/src/main/kotlin/com/bitwarden/ui/platform/components/fab/BitwardenExpandableFloatingActionButton.kt` (+47 -80) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/components/fab/model/ExpandableFabIcon.kt` (+11 -0) ➕ `ui/src/main/kotlin/com/bitwarden/ui/platform/components/fab/model/ExpandableFabOption.kt` (+13 -0) </details> ### 📄 Description ## 🎟️ Tracking N/A ## 📔 Objective This PR simplifies the `BitwardenExpandableFloatingActionButton`. * Removed the need for custom classes and generics * Simplified the expanded state * Fixed state restoration after config change (this is what started it all 😄 ) ## ⏰ Reminders before review - Contributor guidelines followed - All formatters and local linters executed and passed - Written new unit and / or integration tests where applicable - Protected functional changes with optionality (feature flags) - Used internationalization (i18n) for all UI strings - CI builds passed - Communicated to DevOps any deployment requirements - Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team ## 🦮 Reviewer guidelines <!-- Suggested interactions but feel free to use (or not) as you desire! --> - 👍 (`:+1:`) or similar for great changes - 📝 (`:memo:`) or ℹ️ (`:information_source:`) for notes or general info - ❓ (`:question:`) for questions - 🤔 (`:thinking:`) or 💭 (`:thought_balloon:`) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (`:art:`) for suggestions / improvements - ❌ (`:x:`) or ⚠️ (`:warning:`) for more significant problems or concerns needing attention - 🌱 (`:seedling:`) or ♻️ (`:recycle:`) for future improvements or indications of technical debt - ⛏ (`:pick:`) for minor or nitpick changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-18 15:37:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#32223
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?