github-starred/android
2
0
Fork 0
mirror of https://github.com/bitwarden/android.git synced 2026-03-13 13:44:36 -05:00
Code Issues 144 Packages Projects Releases 116 Wiki Activity

[PR #1924] [MERGED] [PS-674] Mobile: Accessibility - expand label/name for password generator toggles #3222

New Issue
Closed
opened 2025-11-26 23:29:54 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-26 23:29:54 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/bitwarden/android/pull/1924
Author: @andrebispo5
Created: 5/25/2022
Status: ✅ Merged
Merged: 5/25/2022
Merged by: @andrebispo5

Base: master ← Head: bug/ps-674-passgen-voiceover

📝 Commits (1)

  • 29930f6 PS-674: Accessibility password generator toggles

📊 Changes

3 files changed (+60 additions, -8 deletions)

View changed files

📝 src/App/Pages/Generator/GeneratorPage.xaml (+24 -8)
📝 src/App/Resources/AppResources.Designer.cs (+24 -0)
📝 src/App/Resources/AppResources.resx (+12 -0)

📄 Description

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Fix accessibility text for password generator toggles.
The toggles should have a clear announcement that is understandable for assistive technology users.

Code changes

  • GeneratorPage.xaml: Added new accessibility text.
  • AppResources.resx: iOS VoiceOver does not pronounce "a to z" correctly, had to use "A to Z" on lowercase to have the expect result.

Before you submit

  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/bitwarden/android/pull/1924 **Author:** [@andrebispo5](https://github.com/andrebispo5) **Created:** 5/25/2022 **Status:** ✅ Merged **Merged:** 5/25/2022 **Merged by:** [@andrebispo5](https://github.com/andrebispo5) **Base:** `master` ← **Head:** `bug/ps-674-passgen-voiceover` --- ### 📝 Commits (1) - [`29930f6`](https://github.com/bitwarden/android/commit/29930f64a69afc90b139589dca0ef0dd1caba77a) PS-674: Accessibility password generator toggles ### 📊 Changes **3 files changed** (+60 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/App/Pages/Generator/GeneratorPage.xaml` (+24 -8) 📝 `src/App/Resources/AppResources.Designer.cs` (+24 -0) 📝 `src/App/Resources/AppResources.resx` (+12 -0) </details> ### 📄 Description ## Type of change - [X] Bug fix - [ ] New feature development - [ ] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ## Objective Fix accessibility text for password generator toggles. The toggles should have a clear announcement that is understandable for assistive technology users. ## Code changes <!--Explain the changes you've made to each file or major component. This should help the reviewer understand your changes--> <!--Also refer to any related changes or PRs in other repositories--> * **GeneratorPage.xaml:** Added new accessibility text. * **AppResources.resx:** iOS VoiceOver does not pronounce "a to z" correctly, had to use "A to Z" on lowercase to have the expect result. ## Before you submit - [ ] I have added **unit tests** where it makes sense to do so (encouraged but not required) - [ ] This change requires a **documentation update** (notify the documentation team) - [ ] This change has particular **deployment requirements** (notify the DevOps team) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-26 23:29:54 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
app:authenticator
app:password-manager
bug
bug-passkey
customer-support
duplicate
enhancement
good first issue
help wanted
needs-reply
needs-response
pull-request
Mirrored from GitHub Pull Request
 question
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/android#3222
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?